Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: sync/notifier/invalidation_notifier_unittest.cc

Issue 10795018: [Sync] Remove unneeded 'using syncer::' lines and 'syncer::' scopings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fiix indent Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « sync/notifier/invalidation_notifier.cc ('k') | sync/notifier/invalidation_util.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "sync/notifier/invalidation_notifier.h" 5 #include "sync/notifier/invalidation_notifier.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "jingle/notifier/base/fake_base_task.h" 9 #include "jingle/notifier/base/fake_base_task.h"
10 #include "jingle/notifier/base/notifier_options.h" 10 #include "jingle/notifier/base/notifier_options.h"
(...skipping 30 matching lines...) Expand all
41 const std::string& initial_invalidation_state) { 41 const std::string& initial_invalidation_state) {
42 notifier::NotifierOptions notifier_options; 42 notifier::NotifierOptions notifier_options;
43 // Note: URLRequestContextGetters are ref-counted. 43 // Note: URLRequestContextGetters are ref-counted.
44 notifier_options.request_context_getter = 44 notifier_options.request_context_getter =
45 new TestURLRequestContextGetter(message_loop_.message_loop_proxy()); 45 new TestURLRequestContextGetter(message_loop_.message_loop_proxy());
46 invalidation_notifier_.reset( 46 invalidation_notifier_.reset(
47 new InvalidationNotifier( 47 new InvalidationNotifier(
48 scoped_ptr<notifier::PushClient>(new notifier::FakePushClient()), 48 scoped_ptr<notifier::PushClient>(new notifier::FakePushClient()),
49 InvalidationVersionMap(), 49 InvalidationVersionMap(),
50 initial_invalidation_state, 50 initial_invalidation_state,
51 syncer::MakeWeakHandle(mock_tracker_.AsWeakPtr()), 51 MakeWeakHandle(mock_tracker_.AsWeakPtr()),
52 "fake_client_info")); 52 "fake_client_info"));
53 invalidation_notifier_->AddObserver(&mock_observer_); 53 invalidation_notifier_->AddObserver(&mock_observer_);
54 } 54 }
55 55
56 void ResetNotifier() { 56 void ResetNotifier() {
57 invalidation_notifier_->RemoveObserver(&mock_observer_); 57 invalidation_notifier_->RemoveObserver(&mock_observer_);
58 // Stopping the invalidation notifier stops its scheduler, which deletes any 58 // Stopping the invalidation notifier stops its scheduler, which deletes any
59 // pending tasks without running them. Some tasks "run and delete" another 59 // pending tasks without running them. Some tasks "run and delete" another
60 // task, so they must be run in order to avoid leaking the inner task. 60 // task, so they must be run in order to avoid leaking the inner task.
61 // Stopping does not schedule any tasks, so it's both necessary and 61 // Stopping does not schedule any tasks, so it's both necessary and
62 // sufficient to drain the task queue before stopping the notifier. 62 // sufficient to drain the task queue before stopping the notifier.
63 message_loop_.RunAllPending(); 63 message_loop_.RunAllPending();
64 invalidation_notifier_.reset(); 64 invalidation_notifier_.reset();
65 } 65 }
66 66
67 MessageLoopForIO message_loop_; 67 MessageLoopForIO message_loop_;
68 scoped_ptr<InvalidationNotifier> invalidation_notifier_; 68 scoped_ptr<InvalidationNotifier> invalidation_notifier_;
69 StrictMock<MockInvalidationStateTracker> mock_tracker_; 69 StrictMock<MockInvalidationStateTracker> mock_tracker_;
70 StrictMock<MockSyncNotifierObserver> mock_observer_; 70 StrictMock<MockSyncNotifierObserver> mock_observer_;
71 notifier::FakeBaseTask fake_base_task_; 71 notifier::FakeBaseTask fake_base_task_;
72 }; 72 };
73 73
74 TEST_F(InvalidationNotifierTest, Basic) { 74 TEST_F(InvalidationNotifierTest, Basic) {
75 CreateAndObserveNotifier("fake_state"); 75 CreateAndObserveNotifier("fake_state");
76 InSequence dummy; 76 InSequence dummy;
77 77
78 syncer::ModelTypePayloadMap type_payloads; 78 ModelTypePayloadMap type_payloads;
79 type_payloads[syncer::PREFERENCES] = "payload"; 79 type_payloads[PREFERENCES] = "payload";
80 type_payloads[syncer::BOOKMARKS] = "payload"; 80 type_payloads[BOOKMARKS] = "payload";
81 type_payloads[syncer::AUTOFILL] = "payload"; 81 type_payloads[AUTOFILL] = "payload";
82 82
83 EXPECT_CALL(mock_observer_, OnNotificationsEnabled()); 83 EXPECT_CALL(mock_observer_, OnNotificationsEnabled());
84 EXPECT_CALL(mock_observer_, 84 EXPECT_CALL(mock_observer_,
85 OnIncomingNotification(type_payloads, 85 OnIncomingNotification(type_payloads,
86 REMOTE_NOTIFICATION)); 86 REMOTE_NOTIFICATION));
87 EXPECT_CALL(mock_observer_, 87 EXPECT_CALL(mock_observer_,
88 OnNotificationsDisabled(TRANSIENT_NOTIFICATION_ERROR)); 88 OnNotificationsDisabled(TRANSIENT_NOTIFICATION_ERROR));
89 EXPECT_CALL(mock_observer_, 89 EXPECT_CALL(mock_observer_,
90 OnNotificationsDisabled(NOTIFICATION_CREDENTIALS_REJECTED)); 90 OnNotificationsDisabled(NOTIFICATION_CREDENTIALS_REJECTED));
91 // Note no expectation on mock_tracker_, as we initialized with 91 // Note no expectation on mock_tracker_, as we initialized with
92 // non-empty initial_invalidation_state above. 92 // non-empty initial_invalidation_state above.
93 93
94 // TODO(tim): This call should be a no-op, Remove once bug 124140 and 94 // TODO(tim): This call should be a no-op, Remove once bug 124140 and
95 // associated issues are fixed. 95 // associated issues are fixed.
96 invalidation_notifier_->SetStateDeprecated("fake_state"); 96 invalidation_notifier_->SetStateDeprecated("fake_state");
97 invalidation_notifier_->SetUniqueId("fake_id"); 97 invalidation_notifier_->SetUniqueId("fake_id");
98 invalidation_notifier_->UpdateCredentials("foo@bar.com", "fake_token"); 98 invalidation_notifier_->UpdateCredentials("foo@bar.com", "fake_token");
99 99
100 invalidation_notifier_->OnNotificationsEnabled(); 100 invalidation_notifier_->OnNotificationsEnabled();
101 101
102 ObjectIdPayloadMap id_payloads; 102 ObjectIdPayloadMap id_payloads;
103 for (syncer::ModelTypePayloadMap::const_iterator it = type_payloads.begin(); 103 for (ModelTypePayloadMap::const_iterator it = type_payloads.begin();
104 it != type_payloads.end(); ++it) { 104 it != type_payloads.end(); ++it) {
105 invalidation::ObjectId id; 105 invalidation::ObjectId id;
106 ASSERT_TRUE(RealModelTypeToObjectId(it->first, &id)); 106 ASSERT_TRUE(RealModelTypeToObjectId(it->first, &id));
107 id_payloads[id] = "payload"; 107 id_payloads[id] = "payload";
108 } 108 }
109 invalidation_notifier_->OnInvalidate(id_payloads); 109 invalidation_notifier_->OnInvalidate(id_payloads);
110 110
111 invalidation_notifier_->OnNotificationsDisabled( 111 invalidation_notifier_->OnNotificationsDisabled(
112 TRANSIENT_NOTIFICATION_ERROR); 112 TRANSIENT_NOTIFICATION_ERROR);
113 invalidation_notifier_->OnNotificationsDisabled( 113 invalidation_notifier_->OnNotificationsDisabled(
(...skipping 14 matching lines...) Expand all
128 ResetNotifier(); 128 ResetNotifier();
129 129
130 CreateAndObserveNotifier("fake_state"); 130 CreateAndObserveNotifier("fake_state");
131 // Should do nothing. 131 // Should do nothing.
132 invalidation_notifier_->SetStateDeprecated("more_spurious_fake_state"); 132 invalidation_notifier_->SetStateDeprecated("more_spurious_fake_state");
133 } 133 }
134 134
135 } // namespace 135 } // namespace
136 136
137 } // namespace syncer 137 } // namespace syncer
OLDNEW
« no previous file with comments | « sync/notifier/invalidation_notifier.cc ('k') | sync/notifier/invalidation_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698