Modify DeterministicSocketData to verify that the sequence number of reads and writes start at zero…

net/socket/socket_test_util.h

Index: net/socket/socket_test_util.h
diff --git a/net/socket/socket_test_util.h b/net/socket/socket_test_util.h
index 384452c084e13960a87c090e0842bc73241b15d0..51b02ba5960739b5adfcecb745158a759f9893b3 100644
--- a/net/socket/socket_test_util.h
+++ b/net/socket/socket_test_util.h
@@ -217,7 +217,14 @@ class StaticSocketDataProvider : public SocketDataProvider {
   virtual MockWriteResult OnWrite(const std::string& data) OVERRIDE;
   virtual void Reset() OVERRIDE;
 
+ protected:
+  StaticSocketDataProvider(bool verify_sequence_numbers,
+                           MockRead* reads, size_t reads_count,
+                           MockWrite* writes, size_t writes_count);

[Ryan Sleevi, 2012/07/18 18:02:13]

Is there a reason this isn't the default behaviour?

It seems troublesome to introduce an overloaded constructor that differs on only
the bool, and it's not clear from this CL what it buys. After all, the omitted
path is the same as verify_sequence_numbers == false

Alternatively, if this is only for DeterministicSocketDataProvider, I would move
this method there and have it handle checking inputs itself.

[Ryan Hamilton, 2012/07/18 18:45:06]

It's not the default behavior because StaticSocketDataProvider doesn't really
need sequence numbers.  It's really only the Deterministic version which does. 
(And also Ordered, but that is evil).
Fair enough, though I did not want to change all of the places where we
construct StaticSocketDataProviders in all the tests.
 
Ah, ok.  So I actually started off trying to do that, but reads_ and writes_ are
private, not protected so they are not visible to Deterministic.  How bout I
simply make the Verify() method protected, and call it in the Deterministic
constructor.

+
  private:
+  void VerifyCorrectSequenceNumbers();
+
   MockRead* reads_;
   size_t read_index_;
   size_t read_count_;