Add an iOS implementation for base::PathService::Get() with path key DIR_APP_DATA.

base/base_paths_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths_mac.h"
 
 #include <dlfcn.h>
 #import <Foundation/Foundation.h>
 #include <mach-o/dyld.h>
 
@@ skipping 41 matching lines @@
 bool PathProviderMac(int key, FilePath* result) {
   switch (key) {
     case base::FILE_EXE:
       GetNSExecutablePath(result);
       return true;
     case base::FILE_MODULE:
       return GetModulePathForAddress(result,
           reinterpret_cast<const void*>(&base::PathProviderMac));
     case base::DIR_CACHE:
       return base::mac::GetUserDirectory(NSCachesDirectory, result);
-    case base::DIR_APP_DATA:
+    case base::DIR_APP_DATA: {
+#if defined(OS_IOS)

[rohitrao (ping after 24h), 2012/07/18 16:01:34]

bool success = base::mac::GetUserDirectory(NSApplicationSupportDirectory,
                                                    result);
#if defined(OS_IOS)
if (success && !file_util::PathExists(*result))
  success = file_util::CreateDirectory(*result);
#endif
return success;


I wonder if we can drop the ifdef and push this through for desktop as well.

[chenyu, 2012/07/18 16:43:32]

Done. I keep the if-def for now and will remove it if it is recommended.

(actually base::mac::GetUserDirectory() looks confusing to me. The comment gives
the impression that it returns true and fill result only when the directory is
found, but it calls NSSearchPathForDirectoriesInDomains(), which has no
guarantee that the returned directories exist) 

On 2012/07/18 16:01:34, rohitrao wrote:

+      // On IOS, this directory does not exist unless it is created explicitly.
+      bool success = base::mac::GetUserDirectory(NSApplicationSupportDirectory,
+                                                 result);
+      if (success && !file_util::PathExists(*result) &&
+          !file_util::CreateDirectory(*result)) {
+        return false;
+      }
+      return success;
+#else
       return base::mac::GetUserDirectory(NSApplicationSupportDirectory, result);
+#endif  // defined(OS_IOS)
+    }
     case base::DIR_SOURCE_ROOT: {
       // Go through PathService to catch overrides.
       if (!PathService::Get(base::FILE_EXE, result))
         return false;
 
       // Start with the executable's directory.
       *result = result->DirName();
 
 #if !defined(OS_IOS)
       if (base::mac::AmIBundled()) {
         // The bundled app executables (Chromium, TestShell, etc) live five
         // levels down, eg:
         // src/xcodebuild/{Debug|Release}/Chromium.app/Contents/MacOS/Chromium
         *result = result->DirName().DirName().DirName().DirName().DirName();
       } else {
         // Unit tests execute two levels deep from the source root, eg:
         // src/xcodebuild/{Debug|Release}/base_unittests
         *result = result->DirName().DirName();
       }
 #endif
       return true;
     }
     default:
       return false;
   }
 }
 
 }  // namespace base