Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Issue 10795007: Fire the onchange event when autocompleting usernames for password forms. (Closed)

Created:
8 years, 5 months ago by Ilya Sherman
Modified:
8 years, 5 months ago
Reviewers:
dhollowa
CC:
chromium-reviews, dhollowa+watch_chromium.org, brettw-cc_chromium.org, Ilya Sherman, dyu1, darin-cc_chromium.org
Visibility:
Public.

Description

Fire the onchange event when autocompleting usernames for password forms. BUG=137769 TEST=Double-click in the username field of a password form to bring up the autocomplete menu. Select an entry to fill just that field, then click off the field to transfer focus away. The onchange event should be fired for that field. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/renderer/autofill/password_autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
8 years, 5 months ago (2012-07-18 05:13:57 UTC) #1
dhollowa
lgtm
8 years, 5 months ago (2012-07-18 14:44:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10795007/1
8 years, 5 months ago (2012-07-18 20:59:55 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 22:34:22 UTC) #4
Change committed as 147323

Powered by Google App Engine
This is Rietveld 408576698