Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10793035: Add flag to Java -> JavaScript to disable exposing inherited methods. (Closed)

Created:
8 years, 5 months ago by David Trainor- moved to gerrit
Modified:
8 years, 5 months ago
Reviewers:
Ted C, joth, Steve Block
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Add flag to Java -> JavaScript to disable exposing inherited methods. Add a flag that allows Java Object injection into JavaScript to specify whether or not only publicly declared methods of the specified class can be injected or whether all public methods of a class should be injected (the current default). This allows the specific APIs to only inject the few methods that should be injected and not unknowingly expose any other methods (those include getClass, getField, getMethod, getAnnotation, etc.. anything from Object or other super classes). In addition, this flag is passed down to other Java Object injections that happen as the result of Objects being returned from method calls. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147281

Patch Set 1 #

Patch Set 2 : Fixed commit description. Rebased. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -17 lines) Patch
M content/browser/renderer_host/java/java_bound_object.h View 3 chunks +12 lines, -4 lines 0 comments Download
M content/browser/renderer_host/java/java_bound_object.cc View 8 chunks +49 lines, -13 lines 1 comment Download

Messages

Total messages: 7 (0 generated)
David Trainor- moved to gerrit
8 years, 5 months ago (2012-07-17 23:44:09 UTC) #1
Steve Block
lgtm Should probably remove the commit message about ContentView, as it's rather confusing at this ...
8 years, 5 months ago (2012-07-18 09:30:38 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-18 17:20:26 UTC) #3
joth
lgtm
8 years, 5 months ago (2012-07-18 17:25:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/10793035/10001
8 years, 5 months ago (2012-07-18 17:25:36 UTC) #5
joth
latent comment....... fyi https://chromiumcodereview.appspot.com/10793035/diff/10001/content/browser/renderer_host/java/java_bound_object.cc File content/browser/renderer_host/java/java_bound_object.cc (right): https://chromiumcodereview.appspot.com/10793035/diff/10001/content/browser/renderer_host/java/java_bound_object.cc#newcode852 content/browser/renderer_host/java/java_bound_object.cc:852: kReturningInteger)); after the fact -- just ...
8 years, 5 months ago (2012-07-18 17:28:39 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 19:02:17 UTC) #7
Change committed as 147281

Powered by Google App Engine
This is Rietveld 408576698