Issue 10793033: Fix cookie sheet icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10793033: Fix cookie sheet icons. (Closed)

Created:
8 years, 5 months ago by Avi (use Gerrit)

Modified:
8 years, 5 months ago

Reviewers:
Robert Sesek

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix cookie sheet icons. BUG=137201 TEST=as in bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147130

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -7 lines)			Patch
	M	third_party/apple_sample_code/ImageAndTextCell.m	View		1 chunk	+7 lines, -7 lines	1 comment	Download
	M	third_party/apple_sample_code/README.chromium	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

LGTM https://chromiumcodereview.appspot.com/10793033/diff/1/third_party/apple_sample_code/ImageAndTextCell.m File third_party/apple_sample_code/ImageAndTextCell.m (right): https://chromiumcodereview.appspot.com/10793033/diff/1/third_party/apple_sample_code/ImageAndTextCell.m#newcode125 third_party/apple_sample_code/ImageAndTextCell.m:125: imageFrame.origin.y += ceil((cellFrame.size.height - imageSize.height) / 2); Technically ...

8 years, 5 months ago (2012-07-17 21:41:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10793033/1

8 years, 5 months ago (2012-07-17 21:44:37 UTC) #3

Change committed as 147130

Expand Messages | Collapse Messages