Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 10793004: Add media_unittest test suite data files on Android. (Closed)

Created:
8 years, 5 months ago by Shouqun Liu
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, bulach
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add media_unittest test suite data files on Android. BUG= TEST=media_unittest on Android Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146794

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/pylib/single_test_runner.py View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Shouqun Liu
This patch adds some test data files required by some cases in media_unittest, thanks for ...
8 years, 5 months ago (2012-07-16 07:48:02 UTC) #1
bulach
thanks shoqun! one suggestion below: http://codereview.chromium.org/10793004/diff/1/build/android/pylib/single_test_runner.py File build/android/pylib/single_test_runner.py (right): http://codereview.chromium.org/10793004/diff/1/build/android/pylib/single_test_runner.py#newcode232 build/android/pylib/single_test_runner.py:232: 'media/test/data/ten_byte_file', we have this ...
8 years, 5 months ago (2012-07-16 09:26:03 UTC) #2
Shouqun Liu
On 2012/07/16 09:26:03, bulach wrote: > thanks shoqun! > one suggestion below: > > http://codereview.chromium.org/10793004/diff/1/build/android/pylib/single_test_runner.py ...
8 years, 5 months ago (2012-07-16 12:11:32 UTC) #3
bulach
lgtm, thanks!
8 years, 5 months ago (2012-07-16 12:15:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10793004/4001
8 years, 5 months ago (2012-07-16 12:18:04 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-16 13:35:56 UTC) #6
Change committed as 146794

Powered by Google App Engine
This is Rietveld 408576698