Move /seccompsandbox to /sandbox/linux/seccomp-legacy

Move /seccompsandbox to /sandbox/linux/seccomp-legacy


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147179

[jln (very slow on Chromium), 2012-07-17 05:27:11]

Markus, do you mind approving this ?

Before I land it, I'll ping the sheriff and of course babysit the build
afterwards.

[Markus (顧孟勤), 2012-07-17 15:22:40]

lgtm

[ I added a few more people to the CC list who might remember some of the
difficulties that we encountering with doing this previously ]

I am perfectly happy with you attempting to make this change. It is arguably the
correct thing to do. But my recollection from previous attempts to make these
changes was that our infrastructure doesn't deal particularly gracefully with
it. Maybe, that has since been fixed.

So, be prepared to break the bots for a few hours and/or having to roll things
back in an emergency. I would suggest, trying to land the change at a time when
a) you can get the Sheriff's attention, and b) the tree is relatively idle --
but I don't know when that would be.

On the other hand, maybe, everything will go smoothly. That would be nice for a
change.

As for the changelist itself, it looks fine. But I would suggest you pick a name
such as seccomp-legacy. We want to make sure that people know this code is
eventually going to be phased out. We just need to do the switch carefully and
gracefully.

[jln (very slow on Chromium), 2012-07-17 17:53:41]

On 2012/07/17 15:22:40, Markus (顧孟勤) wrote:
> lgtm
> 
> [ I added a few more people to the CC list who might remember some of the
> difficulties that we encountering with doing this previously ]
> 
> I am perfectly happy with you attempting to make this change. It is arguably
the
> correct thing to do. But my recollection from previous attempts to make these
> changes was that our infrastructure doesn't deal particularly gracefully with
> it. Maybe, that has since been fixed.
> 
> So, be prepared to break the bots for a few hours and/or having to roll things
> back in an emergency. I would suggest, trying to land the change at a time
when
> a) you can get the Sheriff's attention, and b) the tree is relatively idle --
> but I don't know when that would be.
> 
> On the other hand, maybe, everything will go smoothly. That would be nice for
a
> change.
> 
> As for the changelist itself, it looks fine. But I would suggest you pick a
name
> such as seccomp-legacy. We want to make sure that people know this code is
> eventually going to be phased out. We just need to do the switch carefully and
> gracefully.

FYI: after discussing this with he sheriff, decided to make the move in two
parts: 1. *add* seccomp-legacy, 2. change the .cc / .h to point there and remove
/seccompsandbox.

[commit-bot: I haz the power, 2012-07-18 01:38:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10792027/5010

[commit-bot: I haz the power, 2012-07-18 01:38:16]

Failed to apply patch for chrome/nacl/DEPS:
While running patch -p1 --forward --force;
patching file chrome/nacl/DEPS
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file chrome/nacl/DEPS.rej

[commit-bot: I haz the power, 2012-07-18 01:47:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10792027/18001

[commit-bot: I haz the power, 2012-07-18 01:47:58]

Failed to apply patch for chrome/nacl/DEPS:
While running patch -p1 --forward --force;
patching file chrome/nacl/DEPS
Hunk #1 FAILED at 3.
1 out of 1 hunk FAILED -- saving rejects to file chrome/nacl/DEPS.rej

[commit-bot: I haz the power, 2012-07-18 03:31:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jln@chromium.org/10792027/18003

[commit-bot: I haz the power, 2012-07-18 04:48:41]

Change committed as 147179