Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: vm/object.cc

Issue 10792019: Address some leftover review comments from previous CL. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | vm/os.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/object.cc
===================================================================
--- vm/object.cc (revision 9718)
+++ vm/object.cc (working copy)
@@ -7830,7 +7830,7 @@
ASSERT(str.IsOneByteString());
const OneByteString& onestr = OneByteString::Cast(str);
int64_t value;
- if (!OS::StringToInteger(onestr.ToCString(), &value)) {
+ if (!OS::StringToInt64(onestr.ToCString(), &value)) {
const Bigint& big = Bigint::Handle(Bigint::New(onestr, space));
ASSERT(!BigintOperations::FitsIntoSmi(big));
ASSERT(!BigintOperations::FitsIntoMint(big));
« no previous file with comments | « no previous file | vm/os.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698