Issue 10792014: Track counts/sizes of CODE sub types with --track-gc-object-stats

Issue 10792014: Track counts/sizes of CODE sub types with --track-gc-object-stats (Closed)

Created:
8 years, 5 months ago by danno

Modified:
8 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Track counts/sizes of CODE sub types with --track-gc-object-stats R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12104

Patch Set 2 : Turn flag off by default #

Total comments: 6

Patch Set 3 : Review feedback #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -107 lines)			Patch
M	src/heap.h	View	1 2	2 chunks	+23 lines, -7 lines	0 comments	Download
M	src/heap.cc	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2	2 chunks	+108 lines, -84 lines	0 comments	Download
M	src/objects.h	View	1 2	1 chunk	+24 lines, -16 lines	0 comments	Download
M	src/v8-counters.h	View	1 2	3 chunks	+18 lines, -0 lines	0 comments	Download
M	src/v8-counters.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (just a few nits). https://chromiumcodereview.appspot.com/10792014/diff/2001/src/heap.h File src/heap.h (right): https://chromiumcodereview.appspot.com/10792014/diff/2001/src/heap.h#newcode1603 src/heap.h:1603: enum { Can we ...

8 years, 5 months ago (2012-07-17 10:48:16 UTC) #1

danno

8 years, 5 months ago (2012-07-17 11:57:10 UTC) #2

Feedback addressed, landing

https://chromiumcodereview.appspot.com/10792014/diff/2001/src/heap.h
File src/heap.h (right):

https://chromiumcodereview.appspot.com/10792014/diff/2001/src/heap.h#newcode1603
src/heap.h:1603: enum {
On 2012/07/17 10:48:16, Michael Starzinger wrote:
> Can we have a short comment above this enum describing how the storage arrays
> look like?

Done.

https://chromiumcodereview.appspot.com/10792014/diff/2001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10792014/diff/2001/src/mark-compact.cc...
src/mark-compact.cc:950: static inline void Visit(Map* map, HeapObject* obj) {
On 2012/07/17 10:48:16, Michael Starzinger wrote:
> Can we move the implementation of this method out right above the
code-specific
> visitor method and just leave the declaration here? I think that would improve
> readability a lot.

Done.

https://chromiumcodereview.appspot.com/10792014/diff/2001/src/objects.h
File src/objects.h (right):

https://chromiumcodereview.appspot.com/10792014/diff/2001/src/objects.h#newco...
src/objects.h:4217: // No more than 16 kinds. The value currently encoded in
four bits in
On 2012/07/17 10:48:16, Michael Starzinger wrote:
> There is an "is" missing in the comment.

Done.

Expand Messages | Collapse Messages