Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 10792003: Android: Disable tests failing on Jellybean devices. (Closed)

Created:
8 years, 5 months ago by nilesh
Modified:
8 years, 5 months ago
Reviewers:
Ted C, Mark Mentovai, Yaron
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Android: Disable tests failing on Jellybean devices. Also enabling some tests which are now working. BUG=137348 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146917

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M base/base.gyp View 2 chunks +0 lines, -9 lines 0 comments Download
M build/android/gtest_filter/base_unittests_disabled View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
nilesh
8 years, 5 months ago (2012-07-14 01:01:10 UTC) #1
Ted C
lgtm
8 years, 5 months ago (2012-07-16 18:09:52 UTC) #2
nilesh
8 years, 5 months ago (2012-07-16 21:22:53 UTC) #3
Yaron
lgtm
8 years, 5 months ago (2012-07-16 21:24:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10792003/1
8 years, 5 months ago (2012-07-16 21:24:18 UTC) #5
commit-bot: I haz the power
Presubmit check for 10792003-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-16 21:24:20 UTC) #6
nilesh
Mark, Can you please look at base/ changes. Thanks.
8 years, 5 months ago (2012-07-16 21:27:04 UTC) #7
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-16 21:31:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10792003/1
8 years, 5 months ago (2012-07-16 21:33:17 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-16 22:53:30 UTC) #10
Change committed as 146917

Powered by Google App Engine
This is Rietveld 408576698