Issue 10791002: Finish commit 146665.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10791002: Finish commit 146665. (Closed)

Created:
8 years, 5 months ago by Nicolas Zea

Modified:
8 years, 5 months ago

Reviewers:

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Finish commit 146665: [Sync] Refactor sync configuration logic. Only the last patchset (which was a partial diff) was committed.. Original codereview at: https://chromiumcodereview.appspot.com/10780002/ TBR=rlarocque@chromium.org BUG=129665 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146677

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+823 lines, -565 lines)			Patch
M	chrome/browser/sync/glue/backend_data_type_configurer.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/data_type_manager_impl_unittest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.h	View	4 chunks	+27 lines, -46 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View	12 chunks	+159 lines, -225 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.h	View	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.cc	View	2 chunks	+13 lines, -29 lines	0 comments	Download
M	sync/engine/sync_scheduler.h	View	5 chunks	+39 lines, -14 lines	0 comments	Download
M	sync/engine/sync_scheduler.cc	View	13 chunks	+157 lines, -93 lines	0 comments	Download
M	sync/engine/sync_scheduler_unittest.cc	View	15 chunks	+118 lines, -73 lines	0 comments	Download
M	sync/engine/sync_scheduler_whitebox_unittest.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	sync/internal_api/public/sync_manager.h	View	5 chunks	+31 lines, -18 lines	0 comments	Download
M	sync/internal_api/sync_manager.cc	View	12 chunks	+106 lines, -52 lines	0 comments	Download
M	sync/internal_api/syncapi_unittest.cc	View	5 chunks	+125 lines, -1 line	0 comments	Download
M	sync/sync.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/syncable/directory.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	sync/syncable/directory.cc	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	sync/syncable/syncable_mock.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	sync/test/callback_counter.h	View	1 chunk	+28 lines, -0 lines	0 comments	Download