Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Issue 10790144: Revert 148046 - Revert 147650 - Implement installation of the Chrome App Host. (Closed)

Created:
8 years, 5 months ago by laforge
Modified:
8 years, 5 months ago
Reviewers:
laforge
CC:
chromium-reviews, grt+watch_chromium.org
Visibility:
Public.

Description

Revert 148046 - Revert 147650 - Implement installation of the Chrome App Host. The Chrome App Host is a simple exe that delegates to a Chrome Binaries installation at user or system level. If no installation is available, it will trigger an installation. The Chrome App Host prevents the Chrome Binaries from being uninstalled, except in the case of an upgrade to system-level. The Chrome App Host is implemented in this uncommitted CL: http://codereview.chromium.org/10559090/ . BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10665002 TBR=erikwright@chromium.org Review URL: https://chromiumcodereview.appspot.com/10818021 TBR=laforge@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1258 lines, -545 lines) Patch
M chrome/app/chromium_strings.grd View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/chrome_installer.gypi View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_installer_util.gypi View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/appid.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome_appid.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/installer/mini_installer/configuration.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/installer/mini_installer/configuration.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M chrome/installer/mini_installer/mini_installer.cc View 3 chunks +32 lines, -23 lines 0 comments Download
M chrome/installer/setup/chrome_frame_quick_enable.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/setup/install_worker.h View 2 chunks +19 lines, -6 lines 0 comments Download
M chrome/installer/setup/install_worker.cc View 16 chunks +243 lines, -131 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 12 chunks +211 lines, -126 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 11 chunks +167 lines, -120 lines 0 comments Download
M chrome/installer/util/browser_distribution.h View 2 chunks +1 line, -6 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 5 chunks +10 lines, -11 lines 0 comments Download
D chrome/installer/util/browser_distribution_unittest.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/installer/util/channel_info.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/installer/util/channel_info.cc View 4 chunks +11 lines, -0 lines 0 comments Download
A + chrome/installer/util/chrome_app_host_distribution.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/util/chrome_app_host_distribution.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/util/chrome_app_host_operations.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/util/chrome_app_host_operations.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/util/chrome_binaries_operations.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/installer/util/chrome_binaries_operations.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/installer/util/chrome_frame_operations.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/chromium_binaries_distribution.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/installation_state.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/installer/util/installation_state.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/installer/util/installation_validator.h View 5 chunks +45 lines, -1 line 0 comments Download
M chrome/installer/util/installation_validator.cc View 11 chunks +233 lines, -33 lines 0 comments Download
M chrome/installer/util/installation_validator_unittest.cc View 4 chunks +27 lines, -9 lines 0 comments Download
M chrome/installer/util/installer_state.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/installer/util/installer_state.cc View 2 chunks +126 lines, -6 lines 0 comments Download
M chrome/installer/util/master_preferences.h View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/installer/util/master_preferences.cc View 5 chunks +8 lines, -1 line 0 comments Download
M chrome/installer/util/master_preferences_constants.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/installer/util/master_preferences_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/util/product.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/installer/util/product.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/installer/util/util_constants.h View 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/installer/util/util_constants.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
laforge
8 years, 5 months ago (2012-07-24 14:58:15 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698