Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 10790141: Revert "Revert 148074 - Pass the render process id to the FrameNavigationState." (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 5 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Revert "Revert 148074 - Pass the render process id to the FrameNavigationState." It's used in addition to frame ids to identify frames correctly. Also expose the processId via webNavigation.getFrame and getAllFrames BUG=136090 TEST=ExtensionApiTest.WebNavigationGetFrame Original review: https://chromiumcodereview.appspot.com/10805066 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148204

Patch Set 1 #

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review The biggest difference is that I removed FrameID kInvalidID; and replaced it with ...
8 years, 5 months ago (2012-07-24 11:54:36 UTC) #1
Matt Perry
lgtm
8 years, 5 months ago (2012-07-24 19:30:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10790141/1
8 years, 5 months ago (2012-07-24 19:55:44 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 21:27:48 UTC) #4
Change committed as 148204

Powered by Google App Engine
This is Rietveld 408576698