Issue 10790138: Prepare push to trunk. Now working on version 3.12.16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10790138: Prepare push to trunk. Now working on version 3.12.16. (Closed)

Created:
8 years, 5 months ago by Yang

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prepare push to trunk. Now working on version 3.12.16. R=jkummerow@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12179

Patch Set 1 #

Total comments: 4

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+34 lines, -0 lines	4 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 5 months ago (2012-07-24 07:52:26 UTC) #2

LGTM with nits.

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog
File ChangeLog (right):

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode6
ChangeLog:6: Added dependency to HLoadKeyed* instructions to prevent invalid
hoisting.
nit: long line

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode9
ChangeLog:9: Enabled building V8 for Android on Mac
nit: missing full stop. Also, let's make this s/V8/d8/

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode17
ChangeLog:17: Fixed Windows build spam.
I don't think this is relevant.

https://chromiumcodereview.appspot.com/10790138/diff/1/ChangeLog#newcode20
ChangeLog:20: Preserve rsi when probing for CPU features.
Is this visible to embedders/users?

Expand Messages | Collapse Messages