Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10790133: Enable Verizon Activation from OOBE/Login screen. (Closed)

Created:
8 years, 5 months ago by rkc
Modified:
8 years, 4 months ago
Reviewers:
sadrul, zel, sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Enable Verizon Activation from OOBE/Login screen. With Verizon's activation now coming in a separate modal dialog, there is no reason for us to restrict this to only once the user has logged in. Allows users to activate Verizon from the login screen or OOBE. The user should still not be able to activate from the lock screen though. Also make the modal activation dialog the default option. Review requested, zelidrag@ - main review sky@ - OWNER's review for, chrome/browser/ui/views/ash chrome/browser/ui/webui/chromeos/ sadrul@ - OWNER's review for, chrome/browser/chromeos/status R=zelidrag@chromium.org,sky@chromium.org,sadrul@chromium.org BUG=134475 TEST=The activation option is available at OOBE and the Login screens but not the lock screen. On selecting the activation option, the 3g activation dialog comes up. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=149082

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -32 lines) Patch
M chrome/browser/chromeos/login/login_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/system/ash_system_tray_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_shell_delegate.cc View 1 1 chunk +1 line, -15 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc View 1 2 chunks +15 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rkc
8 years, 5 months ago (2012-07-24 00:39:31 UTC) #1
rkc
On 2012/07/24 00:39:31, Rahul Chaturvedi wrote: Added Sadrul for OWNER's review for chrome/browser/chromeos/status
8 years, 5 months ago (2012-07-24 00:42:20 UTC) #2
sky
http://codereview.chromium.org/10790133/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right): http://codereview.chromium.org/10790133/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc#newcode103 chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:103: (chromeos::WebUILoginDisplayHost*) static_cast
8 years, 5 months ago (2012-07-24 04:28:16 UTC) #3
rkc
http://codereview.chromium.org/10790133/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right): http://codereview.chromium.org/10790133/diff/1/chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc#newcode103 chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:103: (chromeos::WebUILoginDisplayHost*) On 2012/07/24 04:28:20, sky wrote: > static_cast Done.
8 years, 5 months ago (2012-07-24 22:07:03 UTC) #4
sadrul
chromeos/status/ LGTM
8 years, 5 months ago (2012-07-24 22:08:33 UTC) #5
sky
LGTM
8 years, 5 months ago (2012-07-24 23:06:21 UTC) #6
zel
lgtm
8 years, 4 months ago (2012-07-30 20:50:41 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 20:51:41 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698