net: fix a couple of broken certificate tests.

net: fix a couple of broken certificate tests.

BUG=111893
TEST=net_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148192

[Ryan Sleevi, 2012-07-23 21:45:05]

LGTM, two nits below, and it looks like the description needs updating (see
below)

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
File net/base/cert_verify_proc_unittest.cc (right):

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:411: // Bug 111893: This test needs a new
certificate.
Seems like you should remove this BUG and should update the description of the
CL

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:416: X509Certificate::FORMAT_AUTO);
nit: move this to the previous line?

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:437: // Bug 111893: This test needs a new
certificate.
Same here

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:442: X509Certificate::FORMAT_AUTO);
nit: same here

https://chromiumcodereview.appspot.com/10790129/diff/1/net/data/ssl/certifica...
File net/data/ssl/certificates/certse.pem (right):

https://chromiumcodereview.appspot.com/10790129/diff/1/net/data/ssl/certifica...
net/data/ssl/certificates/certse.pem:100: -----END CERTIFICATE-----
nit: Could you include the text from 'openssl x509 -text' for these?

[agl, 2012-07-23 22:14:18]

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
File net/base/cert_verify_proc_unittest.cc (right):

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:411: // Bug 111893: This test needs a new
certificate.
On 2012/07/23 21:45:05, Ryan Sleevi wrote:
> Seems like you should remove this BUG and should update the description of the
> CL

Ah, good point. Thanks.

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:416: X509Certificate::FORMAT_AUTO);
On 2012/07/23 21:45:05, Ryan Sleevi wrote:
> nit: move this to the previous line?

Done.

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:437: // Bug 111893: This test needs a new
certificate.
On 2012/07/23 21:45:05, Ryan Sleevi wrote:
> Same here

Done.

https://chromiumcodereview.appspot.com/10790129/diff/1/net/base/cert_verify_p...
net/base/cert_verify_proc_unittest.cc:442: X509Certificate::FORMAT_AUTO);
On 2012/07/23 21:45:05, Ryan Sleevi wrote:
> nit: same here

Done.

https://chromiumcodereview.appspot.com/10790129/diff/1/net/data/ssl/certifica...
File net/data/ssl/certificates/certse.pem (right):

https://chromiumcodereview.appspot.com/10790129/diff/1/net/data/ssl/certifica...
net/data/ssl/certificates/certse.pem:100: -----END CERTIFICATE-----
On 2012/07/23 21:45:05, Ryan Sleevi wrote:
> nit: Could you include the text from 'openssl x509 -text' for these?

Done.

[commit-bot: I haz the power, 2012-07-23 22:14:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/10790129/5001

[commit-bot: I haz the power, 2012-07-23 22:14:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/10790129/5001

[commit-bot: I haz the power, 2012-07-23 22:34:10]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is android, revision is 147964, job name
was 10790129-5001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).

[commit-bot: I haz the power, 2012-07-24 14:03:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/10790129/5001

[commit-bot: I haz the power, 2012-07-24 14:04:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/10790129/5001

[commit-bot: I haz the power, 2012-07-24 14:23:01]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is android, revision is 148099, job name
was 10790129-5001 (previous was lost) (previous was lost) (previous was lost)
(previous was lost).