Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 10790127: aura: couple of tooltip UX changes: (Closed)

Created:
8 years, 5 months ago by varunjain
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: couple of tooltip UX changes: 1. Hide tooltips when a key is pressed. Tooltip should stay hidden until there is a change in the tooltip. 2. Hide tooltips if they are shown long enough. Tooltip should stay hidden until there is a change in the tooltip. BUG=124078, 137097 TEST=Added new tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148021

Patch Set 1 : patch #

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -0 lines) Patch
M ash/tooltips/tooltip_controller.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/tooltips/tooltip_controller.cc View 1 6 chunks +32 lines, -0 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 2 chunks +123 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
varunjain
8 years, 5 months ago (2012-07-23 20:40:14 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-23 22:36:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10790127/4002
8 years, 5 months ago (2012-07-23 23:47:03 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 01:20:35 UTC) #4
Change committed as 148021

Powered by Google App Engine
This is Rietveld 408576698