Issue 10790126: gdata: Remove use of GetGDataEntryByPath() from Rename

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10790126: gdata: Remove use of GetGDataEntryByPath() from Rename (Closed)

Created:
8 years, 5 months ago by satorux1

Modified:
8 years, 5 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove use of GetGDataEntryByPath() from Rename The number of calles of GetGDataEntryByPath() is reduced from 18 to 17 BUG=137694 TEST=out/Release/unit_tests --gtest_filter=GData*; confirm renaming works as before, including hosted files Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147966

Patch Set 1 #

Total comments: 2

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -9 lines)			Patch
	M	chrome/browser/chromeos/gdata/gdata_file_system.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View		1 chunk	+27 lines, -9 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

lgtm http://codereview.chromium.org/10790126/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.cc File chrome/browser/chromeos/gdata/gdata_file_system.cc (right): http://codereview.chromium.org/10790126/diff/1/chrome/browser/chromeos/gdata/gdata_file_system.cc#newcode1500 chrome/browser/chromeos/gdata/gdata_file_system.cc:1500: if (entry_proto->has_file_specific_info() && I know this is not ...

8 years, 5 months ago (2012-07-23 22:06:00 UTC) #2

satorux1

8 years, 5 months ago (2012-07-23 22:23:58 UTC) #3

http://codereview.chromium.org/10790126/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10790126/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1500: if
(entry_proto->has_file_specific_info() &&
On 2012/07/23 22:06:00, achuith.bhandarkar wrote:
> I know this is not part of this CL, but what happens if this is not true?
> Shouldn't the callback be run with GDATA_FILE_ERROR_NOT_FOUND?

Nothing is wrong with entry_proto->has_file_specific_info() == false, as we are
handling directories as well as files here.

Expand Messages | Collapse Messages