Issue 10790124: chromeos: Add gdata::util::FormatTimeAsString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10790124: chromeos: Add gdata::util::FormatTimeAsString(). (Closed)

Created:
8 years, 5 months ago by Daniel Erat

Modified:
8 years, 5 months ago

Reviewers:
satorux1, kochi

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, satorux1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Add gdata::util::FormatTimeAsString(). This adds a function for formatting a base::Time as an RFC 3339 date/time, e.g. "2012-07-03T12:30:34.318Z". This function complements the existing gdata::util::GetTimeFromString(), and is needed for a later contacts-related change. BUG=128805 TEST=added Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147998

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -4 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_util.h	View	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_util.cc	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_util_unittest.cc	View	3 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10790124/1

8 years, 5 months ago (2012-07-23 20:32:15 UTC) #3

commit-bot: I haz the power

Try job failure for 10790124-1 (retry) (retry) on mac_rel for step "browser_tests". It's a second ...

8 years, 5 months ago (2012-07-23 22:24:20 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10790124/1

8 years, 5 months ago (2012-07-23 22:31:38 UTC) #5

Change committed as 147998

Expand Messages | Collapse Messages