Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Unified Diff: content/renderer/media/audio_message_filter_unittest.cc

Issue 10790121: First step towards moving AudioDevice from content/ to media/audio. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: relaxing the notreached back to log(error) since nacl tests will otherwise fail Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/audio_message_filter_unittest.cc
diff --git a/content/renderer/media/audio_message_filter_unittest.cc b/content/renderer/media/audio_message_filter_unittest.cc
index 203121307720b0f1e1cf817d3f96fad7d37111a5..4608ad1239a2a4b6fdc5c1edf2321c89c2ae8d7d 100644
--- a/content/renderer/media/audio_message_filter_unittest.cc
+++ b/content/renderer/media/audio_message_filter_unittest.cc
@@ -5,29 +5,33 @@
#include "base/message_loop.h"
#include "content/common/media/audio_messages.h"
#include "content/renderer/media/audio_message_filter.h"
+#include "media/audio/audio_device_ipc.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace {
-class MockAudioDelegate : public AudioMessageFilter::Delegate {
+class MockAudioDelegate : public media::AudioDeviceIPCDelegate {
public:
MockAudioDelegate() {
Reset();
}
- virtual void OnStateChanged(AudioStreamState state) {
+ virtual void OnStateChanged(
+ media::AudioDeviceIPCDelegate::State state) OVERRIDE {
state_changed_received_ = true;
state_ = state;
}
virtual void OnStreamCreated(base::SharedMemoryHandle handle,
base::SyncSocket::Handle,
- uint32 length) {
+ uint32 length) OVERRIDE {
created_received_ = true;
handle_ = handle;
length_ = length;
}
+ virtual void OnIPCClosed() OVERRIDE {}
+
virtual void OnVolume(double volume) {
volume_received_ = true;
volume_ = volume;
@@ -35,7 +39,7 @@ class MockAudioDelegate : public AudioMessageFilter::Delegate {
void Reset() {
state_changed_received_ = false;
- state_ = kAudioStreamError;
+ state_ = media::AudioDeviceIPCDelegate::kError;
created_received_ = false;
handle_ = base::SharedMemory::NULLHandle();
@@ -46,7 +50,7 @@ class MockAudioDelegate : public AudioMessageFilter::Delegate {
}
bool state_changed_received() { return state_changed_received_; }
- AudioStreamState state() { return state_; }
+ media::AudioDeviceIPCDelegate::State state() { return state_; }
bool created_received() { return created_received_; }
base::SharedMemoryHandle handle() { return handle_; }
@@ -57,7 +61,7 @@ class MockAudioDelegate : public AudioMessageFilter::Delegate {
private:
bool state_changed_received_;
- AudioStreamState state_;
+ media::AudioDeviceIPCDelegate::State state_;
bool created_received_;
base::SharedMemoryHandle handle_;
@@ -99,9 +103,10 @@ TEST(AudioMessageFilterTest, Basic) {
// AudioMsg_NotifyStreamStateChanged
EXPECT_FALSE(delegate.state_changed_received());
filter->OnMessageReceived(
- AudioMsg_NotifyStreamStateChanged(stream_id, kAudioStreamPlaying));
+ AudioMsg_NotifyStreamStateChanged(
+ stream_id, media::AudioDeviceIPCDelegate::kPlaying));
EXPECT_TRUE(delegate.state_changed_received());
- EXPECT_TRUE(kAudioStreamPlaying == delegate.state());
+ EXPECT_EQ(media::AudioDeviceIPCDelegate::kPlaying, delegate.state());
delegate.Reset();
message_loop.RunAllPending();
@@ -122,7 +127,8 @@ TEST(AudioMessageFilterTest, Delegates) {
EXPECT_FALSE(delegate1.state_changed_received());
EXPECT_FALSE(delegate2.state_changed_received());
filter->OnMessageReceived(
- AudioMsg_NotifyStreamStateChanged(stream_id1, kAudioStreamPlaying));
+ AudioMsg_NotifyStreamStateChanged(
+ stream_id1, media::AudioDeviceIPCDelegate::kPlaying));
EXPECT_TRUE(delegate1.state_changed_received());
EXPECT_FALSE(delegate2.state_changed_received());
delegate1.Reset();
@@ -130,23 +136,11 @@ TEST(AudioMessageFilterTest, Delegates) {
EXPECT_FALSE(delegate1.state_changed_received());
EXPECT_FALSE(delegate2.state_changed_received());
filter->OnMessageReceived(
- AudioMsg_NotifyStreamStateChanged(stream_id2, kAudioStreamPlaying));
+ AudioMsg_NotifyStreamStateChanged(
+ stream_id2, media::AudioDeviceIPCDelegate::kPlaying));
EXPECT_FALSE(delegate1.state_changed_received());
EXPECT_TRUE(delegate2.state_changed_received());
delegate2.Reset();
- // Remove the delegates. Make sure they won't get called.
- filter->RemoveDelegate(stream_id1);
- EXPECT_FALSE(delegate1.state_changed_received());
- filter->OnMessageReceived(
- AudioMsg_NotifyStreamStateChanged(stream_id1, kAudioStreamPlaying));
- EXPECT_FALSE(delegate1.state_changed_received());
-
- filter->RemoveDelegate(stream_id2);
- EXPECT_FALSE(delegate2.state_changed_received());
- filter->OnMessageReceived(
- AudioMsg_NotifyStreamStateChanged(stream_id2, kAudioStreamPlaying));
- EXPECT_FALSE(delegate2.state_changed_received());
-
message_loop.RunAllPending();
}

Powered by Google App Engine
This is Rietveld 408576698