Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5924)

Unified Diff: chrome/browser/resources/file_manager/js/default_action_dialog.js

Issue 10790100: [File Manager] Support HiDPI images in action picker and default action picker (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Correct base Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/file_manager/js/default_action_dialog.js
diff --git a/chrome/browser/resources/file_manager/js/default_action_dialog.js b/chrome/browser/resources/file_manager/js/default_action_dialog.js
index 348ac4a9daabec3c9c88ea55e1759d4f400dff99..6da038e6bfadc2fb351a77746b335dbe00e9c12f 100644
--- a/chrome/browser/resources/file_manager/js/default_action_dialog.js
+++ b/chrome/browser/resources/file_manager/js/default_action_dialog.js
@@ -60,19 +60,21 @@ cr.define('cr.filebrowser', function() {
DefaultActionDialog.prototype.renderItem = function(item) {
var result = this.document_.createElement('li');
- var iconNode = this.document_.createElement('img');
- iconNode.src = item.iconUrl;
- result.appendChild(iconNode);
+ var div = this.document_.createElement('div');
+ div.textContent = item.label;
- var labelNode = this.document_.createElement('span');
- labelNode.textContent = item.label;
- result.appendChild(labelNode);
+ if (item.iconType)
+ div.setAttribute('file-type-icon', item.iconType);
+ else
+ div.style.backgroundImage = 'url(' + item.iconUrl + ')';
+
+ result.appendChild(div);
cr.defineProperty(result, 'lead', cr.PropertyKind.BOOL_ATTR);
cr.defineProperty(result, 'selected', cr.PropertyKind.BOOL_ATTR);
return result;
- }
+ };
/**
* Shows dialog.

Powered by Google App Engine
This is Rietveld 408576698