[File Manager] Support HiDPI images in action picker and default action picker

chrome/browser/resources/file_manager/js/file_tasks.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * This object encapsulates everything related to tasks execution.
  * @param {FileManager} fileManager FileManager instance.
  * @param {Array.<string>} urls List of file urls.
  */
 function FileTasks(fileManager, urls) {
@@ skipping 34 matching lines @@
 
 /**
  * Processes internal tasks.
  * @param {Array.<Object>} tasks The tasks.
  * @private
  */
 FileTasks.prototype.processTasks_ = function(tasks) {
   this.tasks_ = [];
   var id = this.fileManager_.getExtensionId();
 
-  // TODO(kaznacheev): Teach menu items to use HiDPI assets.
-  function getFileTypeIcon(type) {
-    return chrome.extension.getURL(
-        'images/files/file_types/' + type + '.png');
-  }
-
   for (var i = 0; i < tasks.length; i++) {
     var task = tasks[i];
 
     // Tweak images, titles of internal tasks.
     var task_parts = task.taskId.split('|');
     if (task_parts[0] == id) {
       if (task_parts[1] == 'play') {
         // TODO(serya): This hack needed until task.iconUrl is working
         //             (see GetFileTasksFileBrowserFunction::RunImpl).
-        task.iconUrl = getFileTypeIcon('audio');
+        task.iconType = 'audio';
         task.title = loadTimeData.getString('ACTION_LISTEN');
       } else if (task_parts[1] == 'mount-archive') {
-        task.iconUrl = getFileTypeIcon('archive');
+        task.iconType = 'archive';
         task.title = loadTimeData.getString('MOUNT_ARCHIVE');
       } else if (task_parts[1] == 'gallery') {
-        task.iconUrl = getFileTypeIcon('image');
+        task.iconType = 'image';
         task.title = loadTimeData.getString('ACTION_OPEN');
       } else if (task_parts[1] == 'watch') {
-        task.iconUrl = getFileTypeIcon('video');
+        task.iconType = 'video';
         task.title = loadTimeData.getString('ACTION_WATCH');
       } else if (task_parts[1] == 'open-hosted') {
         if (this.urls_.length > 1)
-          task.iconUrl = getFileTypeIcon('generic');
+          task.iconType = 'generic';
         else // Use specific icon.
-          task.iconUrl = getFileTypeIcon(FileType.getIcon(this.urls_[0]));
+          task.iconType = FileType.getIcon(this.urls_[0]);
         task.title = loadTimeData.getString('ACTION_OPEN');
       } else if (task_parts[1] == 'view-pdf') {
         // Do not render this task if disabled.
         if (!loadTimeData.getBoolean('PDF_VIEW_ENABLED'))
           continue;
-        task.iconUrl = getFileTypeIcon('pdf');
+        task.iconType = 'pdf';
         task.title = loadTimeData.getString('ACTION_VIEW');
       } else if (task_parts[1] == 'view-in-browser') {
-        task.iconUrl = getFileTypeIcon('generic');
+        task.iconType = 'generic';
         task.title = loadTimeData.getString('ACTION_VIEW');
       } else if (task_parts[1] == 'install-crx') {
-        task.iconUrl = getFileTypeIcon('generic');
+        task.iconType = 'generic';
         task.title = loadTimeData.getString('INSTALL_CRX');
       }
     }
 
     this.tasks_.push(task);
     if (this.defaultTask_ == null) {
       this.defaultTask_ = task;
     }
   }
 };
@@ skipping 360 matching lines @@
 };
 
 /**
  * Creates combobutton item based on task.
  * @param {Object} task Task to convert.
  * @param {string=} opt_title Title.
  * @return {Object} Item appendable to combobutton drop-down list.
  * @private
  */
 FileTasks.prototype.createCombobuttonItem_ = function(task, opt_title) {
-  return { label: opt_title || task.title, iconUrl: task.iconUrl, task: task };
+  return {
+    label: opt_title || task.title,
+    iconUrl: task.iconUrl,
+    iconType: task.iconType,
+    task: task
+  };
 };
 
 
 /**
  * Decorates a FileTasks method, so it will be actually executed after the tasks
  * are available.
  * This decorator expects an implementation called |method + '_'|.
  * @param {string} method The method name.
  */
 FileTasks.decorate = function(method) {
   var privateMethod = method + '_';
   FileTasks.prototype[method] = function() {
     if (this.tasks_) {
       this[privateMethod].apply(this, arguments);
     } else {
       this.pendingInvocations_.push([privateMethod, arguments]);
     }
     return this;
   };
 };
 
 FileTasks.decorate('display');
 FileTasks.decorate('updateMenuItem');
 FileTasks.decorate('execute');
 FileTasks.decorate('executeDefault');
 FileTasks.decorate('getExternals');