Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 10790100: [File Manager] Support HiDPI images in action picker and default action picker (Closed)

Created:
8 years, 5 months ago by Vladislav Kaznacheev
Modified:
8 years, 5 months ago
Reviewers:
Dmitry Zvorygin
CC:
chromium-reviews, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), tfarina, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

[File Manager] Support HiDPI images in action picker and default action picker Also fixed a minor bug in the default action picker title. BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147851

Patch Set 1 : Correct base #

Total comments: 1

Patch Set 2 : Rebase #

Total comments: 1

Patch Set 3 : Addressed comments #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -93 lines) Patch
M chrome/browser/resources/file_manager/css/combobutton.css View 1 chunk +8 lines, -16 lines 0 comments Download
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +4 lines, -12 lines 0 comments Download
M chrome/browser/resources/file_manager/css/file_types.css View 4 chunks +27 lines, -27 lines 0 comments Download
M chrome/browser/resources/file_manager/js/combobutton.js View 3 chunks +19 lines, -14 lines 0 comments Download
M chrome/browser/resources/file_manager/js/default_action_dialog.js View 1 chunk +9 lines, -7 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/file_tasks.js View 3 chunks +15 lines, -16 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Vladislav Kaznacheev
Please review
8 years, 5 months ago (2012-07-20 15:40:13 UTC) #1
Dmitry Zvorygin
https://chromiumcodereview.appspot.com/10790100/diff/3001/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://chromiumcodereview.appspot.com/10790100/diff/3001/chrome/browser/resources/file_manager/js/file_manager.js#newcode2541 chrome/browser/resources/file_manager/js/file_manager.js:2541: if (extensions.length == 1) { It's my fault here, ...
8 years, 5 months ago (2012-07-20 16:13:42 UTC) #2
Dmitry Zvorygin
LGTM with comments addressed.
8 years, 5 months ago (2012-07-20 16:15:39 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 16:18:54 UTC) #4
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698