PPAPI: Make PPB_MessageLoop_Dev::GetForMainThread work

PPAPI: Make PPB_MessageLoop_Dev::GetForMainThread work

BUG=92909
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154238

[dmichael (off chromium), 2012-08-29 20:47:41]

This is a prerequisite for making (non-blocking) CompletionCallbacks work
properly on background threads.

[bbudge, 2012-08-29 22:26:58]

Couple nits and a question. I'm not very familiar with this code but LGTM.

http://codereview.chromium.org/10790078/diff/20001/ppapi/proxy/plugin_globals.h
File ppapi/proxy/plugin_globals.h (right):

http://codereview.chromium.org/10790078/diff/20001/ppapi/proxy/plugin_globals...
ppapi/proxy/plugin_globals.h:86: MessageLoopResource* loop_for_main_thread();
This looks out of place between the get and set for TLS slot.

http://codereview.chromium.org/10790078/diff/20001/ppapi/shared_impl/resource...
File ppapi/shared_impl/resource_tracker.cc (right):

http://codereview.chromium.org/10790078/diff/20001/ppapi/shared_impl/resource...
ppapi/shared_impl/resource_tracker.cc:164: // only true of the PPB_MessageLoop
resource for the main thread.
Close ')' or just delete '('

Could the key '0' be used for resources not associated with instances? Would
there be any benefit to tracking those like that?

[dmichael (off chromium), 2012-08-30 15:59:10]

Comments addressed.

http://codereview.chromium.org/10790078/diff/20001/ppapi/proxy/plugin_globals.h
File ppapi/proxy/plugin_globals.h (right):

http://codereview.chromium.org/10790078/diff/20001/ppapi/proxy/plugin_globals...
ppapi/proxy/plugin_globals.h:86: MessageLoopResource* loop_for_main_thread();
On 2012/08/29 22:26:58, bbudge1 wrote:
> This looks out of place between the get and set for TLS slot.
Good point, done. I also had the body in the wrong spot relative to other
functions, so I fixed that.

http://codereview.chromium.org/10790078/diff/20001/ppapi/shared_impl/resource...
File ppapi/shared_impl/resource_tracker.cc (right):

http://codereview.chromium.org/10790078/diff/20001/ppapi/shared_impl/resource...
ppapi/shared_impl/resource_tracker.cc:164: // only true of the PPB_MessageLoop
resource for the main thread.
On 2012/08/29 22:26:58, bbudge1 wrote:
> Close ')' or just delete '('
I think it's closed?
"(as of this writing)"

> 
> Could the key '0' be used for resources not associated with instances? Would
> there be any benefit to tracking those like that?
I thought about that. I can't think of any benefit for the 1 resource like this
we have so far, and it might be slightly more complex. E.g., I'd have to make
sure at shutdown to call DidDeleteInstance somewhere so that the ResourceTracker
doesn't leak them.

As far as I can tell, it's almost 6 of one, half dozen of the other. We can
change later if we come up with a reason to put these things in the tracker.

[commit-bot: I haz the power, 2012-08-30 16:00:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dmichael@chromium.org/10790078/24001

[commit-bot: I haz the power, 2012-08-30 20:03:24]

Change committed as 154238