Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10790075: Rename Capturer to VideoFrameCapturer. (Closed)

Created:
8 years, 5 months ago by alexeypa (please no reviews)
Modified:
8 years, 5 months ago
Reviewers:
Wez
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org, tfarina
Visibility:
Public.

Description

Rename Capturer to VideoFrameCapturer. Patch contributed by Thiago Farina <tfarina@chromium.org>;. BUG=104542 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147518

Patch Set 1 #

Patch Set 2 : rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3047 lines, -3031 lines) Patch
D remoting/host/capturer.h View 1 chunk +0 lines, -125 lines 0 comments Download
D remoting/host/capturer_fake.h View 1 chunk +0 lines, -65 lines 0 comments Download
D remoting/host/capturer_fake.cc View 1 chunk +0 lines, -140 lines 0 comments Download
D remoting/host/capturer_helper.h View 1 chunk +0 lines, -82 lines 0 comments Download
D remoting/host/capturer_helper.cc View 1 chunk +0 lines, -116 lines 0 comments Download
D remoting/host/capturer_helper_unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D remoting/host/capturer_linux.cc View 1 chunk +0 lines, -638 lines 0 comments Download
D remoting/host/capturer_mac.mm View 1 1 chunk +0 lines, -777 lines 0 comments Download
D remoting/host/capturer_mac_unittest.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D remoting/host/capturer_unittest.cc View 1 1 chunk +0 lines, -85 lines 0 comments Download
D remoting/host/capturer_win.cc View 1 chunk +0 lines, -569 lines 0 comments Download
M remoting/host/chromoting_host.h View 3 chunks +2 lines, -3 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/client_session.h View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/client_session.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_environment.h View 4 chunks +6 lines, -6 lines 0 comments Download
M remoting/host/desktop_environment.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/event_executor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/event_executor_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/event_executor_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/event_executor_win.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/host_mock_objects.h View 3 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/screen_recorder.h View 5 chunks +7 lines, -8 lines 0 comments Download
M remoting/host/screen_recorder.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/simple_host_process.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A remoting/host/video_frame_capturer.h View 1 chunk +126 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_fake.h View 1 chunk +65 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_fake.cc View 1 chunk +139 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_helper.h View 1 chunk +83 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_helper.cc View 1 chunk +118 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_helper_unittest.cc View 1 chunk +215 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_linux.cc View 1 chunk +638 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_mac.mm View 1 chunk +783 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_mac_unittest.cc View 1 chunk +155 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_unittest.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A remoting/host/video_frame_capturer_win.cc View 1 chunk +571 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 4 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alexeypa (please no reviews)
This is the exact replica of http://codereview.chromium.org/10696134/. Wez, could you please rubber-stamp it?
8 years, 5 months ago (2012-07-19 17:25:12 UTC) #1
Wez
LGTM, but I thought there were still issues with the CL that prevented Thiago from ...
8 years, 5 months ago (2012-07-19 17:45:29 UTC) #2
alexeypa (please no reviews)
On 2012/07/19 17:45:29, Wez wrote: > LGTM, but I thought there were still issues with ...
8 years, 5 months ago (2012-07-19 18:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10790075/6001
8 years, 5 months ago (2012-07-19 18:54:40 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 20:16:05 UTC) #5 
Change committed as 147518

Powered by Google App Engine
This is Rietveld 408576698