Run necessary gclient hooks on the Android bots.

Run gclient hooks on Android bots.
    
This replaces the separate android_gyp step and is called after envsetup is done.

BUG=117407
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147349

[John Grabowski, 2012-07-18 20:59:11]

(Offline we discussed an alternate strategy)

[nilesh, 2012-07-18 21:14:40]

On 2012/07/18 20:59:11, John Grabowski wrote:
> (Offline we discussed an alternate strategy)

Updated the CL. Now calling gclient runhooks after envsetup.

[Yaron, 2012-07-18 21:30:43]

lgtm

Nice. This looks better!

[Isaac (away), 2012-07-18 21:30:49]

lgtm w nit

http://codereview.chromium.org/10790059/diff/5001/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10790059/diff/5001/build/android/buildbot_func...
build/android/buildbot_functions.sh:130: # Should be called only after envsetup
is done.
nit: do we really need a separate bash function / and a buildbot step for this?

[John Grabowski, 2012-07-18 21:42:25]

LGTM

http://codereview.chromium.org/10790059/diff/5001/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10790059/diff/5001/build/android/buildbot_func...
build/android/buildbot_functions.sh:130: # Should be called only after envsetup
is done.
On 2012/07/18 21:30:49, Isaac wrote:
> nit: do we really need a separate bash function / and a buildbot step for
this?

Isaac; absolutely!  Makes it easier for testing bb_baseline_setup.  Here's an
example:

<edit edit>
. ./buildbot_functions.sh
unset bb_run_gclient_hooks
bb_baseline_setup  # test my changes to this function FAST

[nilesh, 2012-07-18 21:48:07]

http://codereview.chromium.org/10790059/diff/5001/build/android/buildbot_func...
File build/android/buildbot_functions.sh (right):

http://codereview.chromium.org/10790059/diff/5001/build/android/buildbot_func...
build/android/buildbot_functions.sh:130: # Should be called only after envsetup
is done.
On 2012/07/18 21:30:49, Isaac wrote:
> nit: do we really need a separate bash function / and a buildbot step for
this?

Linux also has a separate step for this. This replaces the android_gyp step.

[commit-bot: I haz the power, 2012-07-18 21:50:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10790059/5001

[commit-bot: I haz the power, 2012-07-18 22:45:21]

Try job failure for 10790059-5001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-18 22:51:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10790059/5001

[commit-bot: I haz the power, 2012-07-19 00:08:47]

Change committed as 147349