chrome/test/functional/popups.py - Issue 10790055: Convert more PyAuto proxy calls to the JSON interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/popups.py

Issue 10790055: Convert more PyAuto proxy calls to the JSON interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ensure the returned Python string is of type str, not unicode, before passing to GURL. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/functional/popups.py

diff --git a/chrome/test/functional/popups.py b/chrome/test/functional/popups.py

index c49310ae6960a7a2c550e004e74cfa043e530982..3eddb1bd9e1d0b5c79fb9cb8c00b56147610f121 100755

--- a/chrome/test/functional/popups.py

+++ b/chrome/test/functional/popups.py

@@ -68,7 +68,7 @@ class PopupsTest(pyauto.PyUITest):

self.DataDir(), 'popup_blocker', 'popup-window-open.html'))

self.NavigateToURL(file_url, 1, 0)

self.assertEquals('Popup created using window.open',

- self.GetActiveTabTitle(window_index=1))

+ self.GetActiveTabTitle(1))

# Wait until the popup is blocked

self.assertTrue(self.WaitUntil(lambda:

len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)) is 1),