Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1004)

Issue 10790046: Add gyp file for class-dump. (Closed)

Created:
8 years, 5 months ago by lliabraa
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://src.chromium.org/chrome/trunk/deps/third_party/class-dump/
Visibility:
Public.

Description

Add gyp file for class-dump.

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -0 lines) Patch
A class-dump.gyp View 1 1 chunk +178 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
lliabraa
8 years, 5 months ago (2012-07-18 08:36:17 UTC) #1
stuartmorgan
LGTM with nits https://chromiumcodereview.appspot.com/10790046/diff/1/class-dump.gyp File class-dump.gyp (right): https://chromiumcodereview.appspot.com/10790046/diff/1/class-dump.gyp#newcode1 class-dump.gyp:1: { Needs the license block: # ...
8 years, 5 months ago (2012-07-18 10:13:25 UTC) #2
lliabraa
https://chromiumcodereview.appspot.com/10790046/diff/1/class-dump.gyp File class-dump.gyp (right): https://chromiumcodereview.appspot.com/10790046/diff/1/class-dump.gyp#newcode1 class-dump.gyp:1: { On 2012/07/18 10:13:25, stuartmorgan wrote: > Needs the ...
8 years, 5 months ago (2012-07-18 12:08:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/10790046/4002
8 years, 5 months ago (2012-07-18 14:08:16 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 14:08:22 UTC) #5
Change committed as 147231

Powered by Google App Engine
This is Rietveld 408576698