Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Issue 10790028: Change explicit usage of each type of message loop in WaitableEventWatcher tests to instead loop th… (Closed)

Created:
8 years, 5 months ago by leng
Modified:
8 years, 5 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Change explicit usage of each type of message loop in WaitableEventWatcher tests to instead loop through an array of message loop types. This allows for easier-to-read code while including a platform that cannot run the tests on every kind of message loop. Specifically, iOS cannot run the UI loop for unit tests. Un-exclude synchronization/waitable_event_watcher_unittest.cc on ios in base.gyp. BUG=b/6825256 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147198

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -16 lines) Patch
M base/base.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/synchronization/waitable_event_watcher_unittest.cc View 3 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
leng
8 years, 5 months ago (2012-07-17 16:42:19 UTC) #1
stuartmorgan
LGTM +mento for OWNERS (In case you are confused like I was: safe fix, different ...
8 years, 5 months ago (2012-07-17 16:56:58 UTC) #2
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-17 17:19:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10790028/1
8 years, 5 months ago (2012-07-17 17:22:47 UTC) #4
commit-bot: I haz the power
Failed to apply patch for base/base.gyp: While running patch -p1 --forward --force; patching file base/base.gyp ...
8 years, 5 months ago (2012-07-17 17:22:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10790028/6001
8 years, 5 months ago (2012-07-17 17:26:37 UTC) #6
commit-bot: I haz the power
Try job failure for 10790028-6001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-17 18:36:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leng@chromium.org/10790028/6001
8 years, 5 months ago (2012-07-18 04:55:07 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 08:06:52 UTC) #9
Change committed as 147198

Powered by Google App Engine
This is Rietveld 408576698