Adds a way to specify test data files for unittests.

Adds a way to specify test data files for unittests.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146995

[pkl (ping after 24h if needed), 2012-07-16 17:15:33]

LGTM for python code. However, if you have not ran gpylint, you probably should.

http://codereview.chromium.org/10790008/diff/2001/build/copy_test_data.py
File build/copy_test_data.py (right):

http://codereview.chromium.org/10790008/diff/2001/build/copy_test_data.py#new...
build/copy_test_data.py:1: #!/usr/bin/env python
google3 python files do *not* require shebang lines. But I don't know if this is
necessary in this case.

http://codereview.chromium.org/10790008/diff/2001/build/copy_test_data.py#new...
build/copy_test_data.py:31: # Inputs is a list of possibly-space-separated
strings.  Break apart the list
Use triple-" for function doc strings.

http://codereview.chromium.org/10790008/diff/2001/build/copy_test_data.py#new...
build/copy_test_data.py:42: relative_dirname = os.path.dirname(file)
indent 2

http://codereview.chromium.org/10790008/diff/2001/build/copy_test_data.py#new...
build/copy_test_data.py:59: raise WrongNumberOfArgumentsException("<input_files>
required.")
single quote strings.

[rohitrao (ping after 24h), 2012-07-16 17:37:38]

Ready for review now.  I'm going to assume you'll find good ways to make this
cleaner =)

I would love to move the OS==ios condition into copy_test_data.gypi, because I
see that as more of an implementation detail.  I tried baking the action itself
into the gypi, but that felt weird and is not how any of our other includes
work.

[Mark Mentovai, 2012-07-16 17:48:45]

http://codereview.chromium.org/10790008/diff/6001/build/copy_test_data.gypi
File build/copy_test_data.gypi (right):

http://codereview.chromium.org/10790008/diff/6001/build/copy_test_data.gypi#n...
build/copy_test_data.gypi:35: {
If you named this file copy_test_data_ios.gypi, then putting the OS=='ios'
condition in here doesn’t seem as bad, does it?

http://codereview.chromium.org/10790008/diff/6001/build/copy_test_data.py
File build/copy_test_data.py (right):

http://codereview.chromium.org/10790008/diff/6001/build/copy_test_data.py#new...
build/copy_test_data.py:48: if not os.path.exists(output_dir):
This doesn’t really handle the case where what was formerly a file turns into a
directory, or the other way around.

[rohitrao (ping after 24h), 2012-07-17 11:46:41]

This should handle file->directory and directory->file renames now.  I've also
appended _ios to the gypi and py files.

[Mark Mentovai, 2012-07-17 12:43:13]

LGTM otherwise

http://codereview.chromium.org/10790008/diff/8001/build/copy_test_data_ios.gypi
File build/copy_test_data_ios.gypi (right):

http://codereview.chromium.org/10790008/diff/8001/build/copy_test_data_ios.gy...
build/copy_test_data_ios.gypi:44: '../build/copy_test_data_ios.py',
:/

This will only work if the .gyp file is one level in from src, like base is.
That won’t always be the case. You’ll sadly need to use <(DEPTH) instead of ..
here.

[commit-bot: I haz the power, 2012-07-17 13:07:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rohitrao@chromium.org/10790008/2009

[commit-bot: I haz the power, 2012-07-17 14:15:35]

Change committed as 146995