clean use_emulator option for inconsistence issue

clean use_emulator option for inconsistence issue

use_emulator option is taken as integer somewhere but is taken as
boolean in other places. 

Clean this option to be boolean and add another option --emulator_count to set
the count of emulators. 

BUG=137458
TEST=./build/android/run_tests.py -e -n 1 -s base_unittests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146801

[Wei James(wistoch), 2012-07-16 01:43:45]

--jobs option will launch multiple emulator at the same time for testing. 

currently launching multiple emulator with the same avd has issue. will fix it
later.

[bulach, 2012-07-16 09:23:15]

thanks james! I agree with the cleanup, but I'd suggest a different name for the
option. if you agree, please also change the patch description.

http://codereview.chromium.org/10790006/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/10790006/diff/1/build/android/run_tests.py#new...
build/android/run_tests.py:450: action='store_true', default=False,
nit: no need for default=False

http://codereview.chromium.org/10790006/diff/1/build/android/run_tests.py#new...
build/android/run_tests.py:452: option_parser.add_option('-j', '--jobs',
dest='emulator_count',
hmm, j / jobs seem unrelated..
perhaps just keep the long option?
'--emulator_count', then we don't even need the dest param..

[Wei James(wistoch), 2012-07-16 09:42:03]

thanks for the comments. 

description changed and issues fixed. thanks

http://codereview.chromium.org/10790006/diff/1/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/10790006/diff/1/build/android/run_tests.py#new...
build/android/run_tests.py:450: action='store_true', default=False,
On 2012/07/16 09:23:15, bulach wrote:
> nit: no need for default=False

fixed. thanks

http://codereview.chromium.org/10790006/diff/1/build/android/run_tests.py#new...
build/android/run_tests.py:452: option_parser.add_option('-j', '--jobs',
dest='emulator_count',
On 2012/07/16 09:23:15, bulach wrote:
> hmm, j / jobs seem unrelated..
> perhaps just keep the long option?
> '--emulator_count', then we don't even need the dest param..

fixed. thanks

[bulach, 2012-07-16 11:24:46]

lgtm, thanks!

http://codereview.chromium.org/10790006/diff/2002/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/10790006/diff/2002/build/android/run_tests.py#...
build/android/run_tests.py:454: help='Emulator count to run test at the same
time.')
nit: maybe be clearer as:
'Number of emulators to launch for running the tests.'

[Wei James(wistoch), 2012-07-16 12:19:12]

thanks

http://codereview.chromium.org/10790006/diff/2002/build/android/run_tests.py
File build/android/run_tests.py (right):

http://codereview.chromium.org/10790006/diff/2002/build/android/run_tests.py#...
build/android/run_tests.py:454: help='Emulator count to run test at the same
time.')
On 2012/07/16 11:24:46, bulach wrote:
> nit: maybe be clearer as:
> 'Number of emulators to launch for running the tests.'

fixed. thanks

[commit-bot: I haz the power, 2012-07-16 12:56:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/james.wei@intel.com/10790006/4002

[commit-bot: I haz the power, 2012-07-16 14:26:06]

Change committed as 146801