Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: src/compiler.h

Issue 10789039: Make CompilationInfo::~CompilationInfo() virtual so that CompilationInfoWithZone destructs correctl… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 27 matching lines...) Expand all
38 class ScriptDataImpl; 38 class ScriptDataImpl;
39 39
40 // CompilationInfo encapsulates some information known at compile time. It 40 // CompilationInfo encapsulates some information known at compile time. It
41 // is constructed based on the resources available at compile-time. 41 // is constructed based on the resources available at compile-time.
42 class CompilationInfo BASE_EMBEDDED { 42 class CompilationInfo BASE_EMBEDDED {
43 public: 43 public:
44 CompilationInfo(Handle<Script> script, Zone* zone); 44 CompilationInfo(Handle<Script> script, Zone* zone);
45 CompilationInfo(Handle<SharedFunctionInfo> shared_info, Zone* zone); 45 CompilationInfo(Handle<SharedFunctionInfo> shared_info, Zone* zone);
46 CompilationInfo(Handle<JSFunction> closure, Zone* zone); 46 CompilationInfo(Handle<JSFunction> closure, Zone* zone);
47 47
48 ~CompilationInfo(); 48 virtual ~CompilationInfo();
49 49
50 Isolate* isolate() { 50 Isolate* isolate() {
51 ASSERT(Isolate::Current() == isolate_); 51 ASSERT(Isolate::Current() == isolate_);
52 return isolate_; 52 return isolate_;
53 } 53 }
54 Zone* zone() { 54 Zone* zone() {
55 return zone_; 55 return zone_;
56 } 56 }
57 bool is_lazy() const { return IsLazy::decode(flags_); } 57 bool is_lazy() const { return IsLazy::decode(flags_); }
58 bool is_eval() const { return IsEval::decode(flags_); } 58 bool is_eval() const { return IsEval::decode(flags_); }
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 449
450 static void RecordFunctionCompilation(Logger::LogEventsAndTags tag, 450 static void RecordFunctionCompilation(Logger::LogEventsAndTags tag,
451 CompilationInfo* info, 451 CompilationInfo* info,
452 Handle<SharedFunctionInfo> shared); 452 Handle<SharedFunctionInfo> shared);
453 }; 453 };
454 454
455 455
456 } } // namespace v8::internal 456 } } // namespace v8::internal
457 457
458 #endif // V8_COMPILER_H_ 458 #endif // V8_COMPILER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698