lib/dom/scripts/systemfrog.py - Issue 10789010: Do not treat callbacks with no handlers as interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemfrog.py

Issue 10789010: Do not treat callbacks with no handlers as interfaces. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: . Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/dom/scripts/systemfrog.py

diff --git a/lib/dom/scripts/systemfrog.py b/lib/dom/scripts/systemfrog.py

index 215d956ea085a4ea3419d3fdf601e7497ef7edf7..9a8dbb271c2694838481c7d3481fbd1405b03989 100644

--- a/lib/dom/scripts/systemfrog.py

+++ b/lib/dom/scripts/systemfrog.py

@@ -160,10 +160,8 @@ class FrogInterfaceGenerator(BaseGenerator):

return False

if self._system._database.HasInterface(type_name):

interface = self._system._database.GetInterface(type_name)

- if RecognizeCallback(interface):

- # Callbacks are typedef functions so don't have a class.

- return False

- return True

+ # Callbacks are typedef functions so don't have a class.

+ return 'Callback' not in interface.ext_attrs

return False

def _NarrowToImplementationType(self, type_name):

« no previous file with comments | « lib/dom/scripts/generator.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »