Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 10789009: Fix the parameters for creating SpawningServer on Android. (Closed)

Created:
8 years, 5 months ago by Shouqun Liu
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, bulach
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix the parameters for creating SpawningServer on Android. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146933

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M build/android/pylib/base_test_runner.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Shouqun Liu
The parameters of SpawningServer's __init__ method are test_server_spawner_port and test_server_port, so fix it when creating ...
8 years, 5 months ago (2012-07-16 05:33:44 UTC) #1
John Grabowski
LGTM
8 years, 5 months ago (2012-07-16 20:38:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10789009/1
8 years, 5 months ago (2012-07-16 22:39:29 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-17 00:18:55 UTC) #4
Change committed as 146933

Powered by Google App Engine
This is Rietveld 408576698