Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 10787037: browser/ui: Share BookmarkBarInstructions delegate between gtk and views. (Closed)

Created:
8 years, 5 months ago by tfarina
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

browser/ui: Share BookmarkBarInstructions delegate between gtk and views. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148042

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -36 lines) Patch
A chrome/browser/ui/bookmarks/bookmark_bar_instructions_delegate.h View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.h View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.h View 2 chunks +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/gtk/bookmarks/bookmark_bar_instructions_gtk.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.h View 3 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_instructions_view.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tfarina
8 years, 5 months ago (2012-07-17 14:11:06 UTC) #1
Ben Goodger (Google)
8 years, 5 months ago (2012-07-23 21:13:46 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698