Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 10787018: Add support for libxml as a system library target on iOS (Closed)

Created:
8 years, 5 months ago by stuartmorgan
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add support for libxml as a system library target on iOS Restructures the gyp conditions to make the system-lib and non-system-lib paths much clearer, and to ensure that if a new OS tries to use use_system_libxml it won't silently use the non-system path. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146976

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -30 lines) Patch
M build/all.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libxml/libxml.gyp View 2 chunks +49 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
stuartmorgan
This is basically the same reworking that we did for libsql, since the conditionals get ...
8 years, 5 months ago (2012-07-16 18:24:24 UTC) #1
rohitrao (ping after 24h)
lgtm
8 years, 5 months ago (2012-07-17 07:40:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stuartmorgan@chromium.org/10787018/3001
8 years, 5 months ago (2012-07-17 09:27:47 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-17 10:41:15 UTC) #4
Change committed as 146976

Powered by Google App Engine
This is Rietveld 408576698