Add split builder/tester android trybot target

Add split builder/tester android trybot target
    
Also allocate additional bare metal machines for trybot tests.
    
builders "android_builder"
testers "android_tester"
    
To run a try job, use git try -b android_builder


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148898

[M-A Ruel, 2012-07-14 22:32:50]

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:129: annotation_script =
'src/build/android/buildbot_try_compiler.sh'
the difference it really subtle :(

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/slaves.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/slaves.cfg:160: 'builder': ['android'],
You should set it to:
'builder': ['android', 'android_compiler'],

There is no need to split them.

[Isaac (away), 2012-07-16 10:00:10]

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:129: annotation_script =
'src/build/android/buildbot_try_compiler.sh'
On 2012/07/14 22:32:50, Marc-Antoine Ruel wrote:
> the difference it really subtle :(

yes it is, and the scripts are very similar too...  I didn't want to combine
them in case we needed to turn one into an 'exit 0' no-op.

try_compile.sh will be deprecated soon.

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/slaves.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/slaves.cfg:160: 'builder': ['android'],
On 2012/07/14 22:32:50, Marc-Antoine Ruel wrote:
> You should set it to:
> 'builder': ['android', 'android_compiler'],
> 
> There is no need to split them.

Can you explain what that does?  I've never tried to allocate machines for
double duty

[M-A Ruel, 2012-07-16 13:11:44]

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/slaves.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/slaves.cfg:160: 'builder': ['android'],
On 2012/07/16 10:00:10, Isaac wrote:
> On 2012/07/14 22:32:50, Marc-Antoine Ruel wrote:
> > You should set it to:
> > 'builder': ['android', 'android_compiler'],
> > 
> > There is no need to split them.
> 
> Can you explain what that does?  I've never tried to allocate machines for
> double duty

Look at the other configs. The result is the slave is connected to multiple
builders so whichever first builder to request the slave gets it for the
duration of the build, since we limit to one concurrent build per slave. The
main limiting factor in our case is the disk space usage so we try to limit it
to ~5 checkouts, e.g. 5 builders per slave.

[cmp, 2012-07-16 17:29:24]

lgtm with nits and once you've combined builders for the slaves

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/1/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:1406: # Triggerable scheduler for
Android Builder
nit: append period to end of sentence

[Isaac (away), 2012-07-17 16:25:33]

+cc jrg

[M-A Ruel, 2012-07-17 17:33:04]

lgtm

[John Grabowski, 2012-07-17 17:36:35]

LGTM

https://chromiumcodereview.appspot.com/10787011/diff/8001/masters/master.trys...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/8001/masters/master.trys...
masters/master.tryserver.chromium/master.cfg:128: elif builder_name ==
'android_compiler':
Seems like "android_builder" would be a more consistent name with other similar
splits.

[Isaac (away), 2012-07-18 17:06:36]

https://chromiumcodereview.appspot.com/10787011/diff/8001/masters/master.trys...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/8001/masters/master.trys...
masters/master.tryserver.chromium/master.cfg:128: elif builder_name ==
'android_compiler':
It was originally android_builder but maruel suggested I use compiler because
these are all technically 'builders'.  Do you feel strongly?

On 2012/07/17 17:36:35, John Grabowski wrote:
> Seems like "android_builder" would be a more consistent name with other
similar
> splits.
>

[Isaac (away), 2012-07-27 23:18:01]

ptal. Will keep android_test trybot target for now since android_builder target
won't work until we change the zip/extract steps to use google storage.  But CL
is ready to go for our tryserver restart.

[M-A Ruel, 2012-07-27 23:20:04]

lgtm

https://chromiumcodereview.appspot.com/10787011/diff/20001/masters/master.try...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/20001/masters/master.try...
masters/master.tryserver.chromium/master.cfg:610: b_android = CreateBuilder(
I'd appreciate a one-liner comment explaining the difference between them. No
biggies.

[Isaac (away), 2012-07-28 02:32:56]

ready for submit

https://chromiumcodereview.appspot.com/10787011/diff/20001/masters/master.try...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10787011/diff/20001/masters/master.try...
masters/master.tryserver.chromium/master.cfg:610: b_android = CreateBuilder(
On 2012/07/27 23:20:04, Marc-Antoine Ruel wrote:
> I'd appreciate a one-liner comment explaining the difference between them. No
> biggies.

Done.

[commit-bot: I haz the power, 2012-07-28 12:10:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/10787011/27001

[commit-bot: I haz the power, 2012-07-28 12:11:33]

Change committed as 148898