Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10787002: Moved ExtensionMessage* into extensions namespace (Closed)

Created:
8 years, 5 months ago by Devlin
Modified:
8 years, 5 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, timurrrr+watch_chromium.org, brettw-cc_chromium.org, pam+watch_chromium.org, glider+watch_chromium.org, jshin+watch_chromium.org, bruening+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moved ExtensionMessage* into extensions namespace Moved ExtensionMessageBundle, ExtensionMessageService, and ExtensionMessageHandler into extensions namespace. Renamed appropriately. BUG=137298, 117261 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148354

Patch Set 1 : #

Patch Set 2 : Latest master for cq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -1945 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/execute_code_in_tab_function.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
D chrome/browser/extensions/extension_message_handler.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/extensions/extension_message_handler.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/extensions/extension_message_service.h View 1 chunk +0 lines, -151 lines 0 comments Download
D chrome/browser/extensions/extension_message_service.cc View 1 chunk +0 lines, -472 lines 0 comments Download
M chrome/browser/extensions/extension_system.h View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_system.cc View 1 5 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_system_factory.cc View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/extensions/message_handler.h View 3 chunks +11 lines, -7 lines 0 comments Download
A + chrome/browser/extensions/message_handler.cc View 2 chunks +14 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/message_service.h View 6 chunks +11 lines, -10 lines 0 comments Download
A + chrome/browser/extensions/message_service.cc View 25 chunks +47 lines, -48 lines 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_system.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/user_script_master.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/renderer_host/chrome_render_message_filter.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/tab_contents/background_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_common.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.h View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.h View 4 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension_l10n_util_unittest.cc View 16 chunks +18 lines, -19 lines 0 comments Download
M chrome/common/extensions/extension_localization_peer.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/common/extensions/extension_localization_peer_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
D chrome/common/extensions/extension_message_bundle.h View 1 chunk +0 lines, -165 lines 0 comments Download
D chrome/common/extensions/extension_message_bundle.cc View 1 chunk +0 lines, -346 lines 0 comments Download
D chrome/common/extensions/extension_message_bundle_unittest.cc View 1 chunk +0 lines, -425 lines 0 comments Download
A + chrome/common/extensions/message_bundle.h View 5 chunks +17 lines, -13 lines 0 comments Download
A + chrome/common/extensions/message_bundle.cc View 11 chunks +51 lines, -52 lines 0 comments Download
A + chrome/common/extensions/message_bundle_unittest.cc View 18 chunks +59 lines, -55 lines 0 comments Download
M chrome/renderer/extensions/i18n_custom_bindings.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/miscellaneous_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
Simple refactor; review when time allows. Thanks in advance.
8 years, 5 months ago (2012-07-17 17:33:50 UTC) #1
Matt Perry
lgtm
8 years, 5 months ago (2012-07-18 20:18:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/10787002/7001
8 years, 5 months ago (2012-07-25 16:13:32 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-25 17:40:52 UTC) #4 
Change committed as 148354

Powered by Google App Engine
This is Rietveld 408576698