Remove the seccomp filter disable.

Remove the seccomp filter disable.

Now that seccomp filter looks good in 3.5, remove the disable.

BUG=None
TEST=Chrome logs "Enable seccomp filter sandbox...".


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147945

[Jorge Lucangeli Obes, 2012-07-16 21:03:29]

PTAL

What do folks think about not disabling seccomp filter for the next dev release?

[jln (very slow on Chromium), 2012-07-16 21:09:29]

On 2012/07/16 21:03:29, Jorge Lucangeli Obes wrote:
> PTAL
> 
> What do folks think about not disabling seccomp filter for the next dev
release?

I'd be happy to see it enabled again (lgtm)!

But we should be aware that the seccomp policies are currently very rough. They
are reasonably tested on Ubuntu 12.04, but much less so on anything else.
So it's possible that someone who installs 3.5, especially with a different
glibc or ati/nvidia binary driver than what is used in Ubuntu 12.04, will
suddenly run into trouble.

Let's see what Will says.

[cevans, 2012-07-16 21:14:37]

On Mon, Jul 16, 2012 at 2:09 PM, <jln@chromium.org> wrote:

> On 2012/07/16 21:03:29, Jorge Lucangeli Obes wrote:
>
>> PTAL
>>
>
>  What do folks think about not disabling seccomp filter for the next dev
>>
> release?
>
> I'd be happy to see it enabled again (lgtm)!
>
> But we should be aware that the seccomp policies are currently very rough.
> They
> are reasonably tested on Ubuntu 12.04, but much less so on anything else.
> So it's possible that someone who installs 3.5, especially with a different
> glibc or ati/nvidia binary driver than what is used in Ubuntu 12.04, will
> suddenly run into trouble.
>
> Let's see what Will says.
>

Let's wait for 3.5-final to go out. We can then land the re-enable, and any
breakage is our fault, not the fault of the any kernel upgrade.


>
>
https://chromiumcodereview.**appspot.com/10786023/<https://chromiumcodereview...
>

[Chris Evans, 2012-07-22 00:59:51]

LGTM

(Nit: check if there's some include we can remove now that we're not using the
base/ environment API any more).

We can land this now, 3.5 went stable with seccomp BPF yay:
http://lwn.net/Articles/507729/


On 2012/07/16 21:14:37, cevans wrote:
> On Mon, Jul 16, 2012 at 2:09 PM, <mailto:jln@chromium.org> wrote:
> 
> > On 2012/07/16 21:03:29, Jorge Lucangeli Obes wrote:
> >
> >> PTAL
> >>
> >
> >  What do folks think about not disabling seccomp filter for the next dev
> >>
> > release?
> >
> > I'd be happy to see it enabled again (lgtm)!
> >
> > But we should be aware that the seccomp policies are currently very rough.
> > They
> > are reasonably tested on Ubuntu 12.04, but much less so on anything else.
> > So it's possible that someone who installs 3.5, especially with a different
> > glibc or ati/nvidia binary driver than what is used in Ubuntu 12.04, will
> > suddenly run into trouble.
> >
> > Let's see what Will says.
> >
> 
> Let's wait for 3.5-final to go out. We can then land the re-enable, and any
> breakage is our fault, not the fault of the any kernel upgrade.
> 
> 
> >
> >
>
https://chromiumcodereview.**appspot.com/10786023/%3Chttps://chromiumcoderevi...>
> >

[commit-bot: I haz the power, 2012-07-23 18:34:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/10786023/6001

[commit-bot: I haz the power, 2012-07-23 20:00:57]

Try job failure for 10786023-6001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Jorge Lucangeli Obes, 2012-07-23 20:04:45]

On 2012/07/23 20:00:57, I haz the power (commit-bot) wrote:
> Try job failure for 10786023-6001 (retry) on mac_rel for step "browser_tests".
> It's a second try, previously, step "browser_tests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Mac bot failure, Linux-only CL.

[commit-bot: I haz the power, 2012-07-23 20:05:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jorgelo@chromium.org/10786023/6001

[commit-bot: I haz the power, 2012-07-23 21:10:47]

Change committed as 147945