Change explicit usage of each type of message loop in TimerTest to instead loop through an array of…

Change explicit usage of each type of message loop in TimerTest to instead loop through an array of message loop types.

This allows for easier-to-read code while including a platform that cannot run the tests on every kind of message loop.  Specifically, iOS cannot run the UI loop for unit tests.

Un-exclude timer_unittest.cc on ios in base.gyp.

BUG=b/6825060
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146980

[leng, 2012-07-16 15:40:55]

Better array size determination as we discussed.
PTAL, thanks!

[stuartmorgan, 2012-07-16 15:56:14]

LGTM with nit

https://chromiumcodereview.appspot.com/10786013/diff/2001/base/timer_unittest.cc
File base/timer_unittest.cc (right):

https://chromiumcodereview.appspot.com/10786013/diff/2001/base/timer_unittest...
base/timer_unittest.cc:20: #endif  // !OS_IOS
No need for the end comment for such a short ifdef.

[leng, 2012-07-16 16:01:28]

https://chromiumcodereview.appspot.com/10786013/diff/2001/base/timer_unittest.cc
File base/timer_unittest.cc (right):

https://chromiumcodereview.appspot.com/10786013/diff/2001/base/timer_unittest...
base/timer_unittest.cc:20: #endif  // !OS_IOS
On 2012/07/16 15:56:15, stuartmorgan wrote:
> No need for the end comment for such a short ifdef.

Done.

[Mark Mentovai, 2012-07-16 16:04:04]

https://chromiumcodereview.appspot.com/10786013/diff/2002/base/timer_unittest.cc
File base/timer_unittest.cc (right):

https://chromiumcodereview.appspot.com/10786013/diff/2002/base/timer_unittest...
base/timer_unittest.cc:15: MessageLoop::Type testing_message_loops[] = {
const?

[leng, 2012-07-16 16:10:10]

PTAL, Thanks!

https://chromiumcodereview.appspot.com/10786013/diff/2002/base/timer_unittest.cc
File base/timer_unittest.cc (right):

https://chromiumcodereview.appspot.com/10786013/diff/2002/base/timer_unittest...
base/timer_unittest.cc:15: MessageLoop::Type testing_message_loops[] = {
On 2012/07/16 16:04:04, Mark Mentovai wrote:
> const?

Done.

[Mark Mentovai, 2012-07-16 16:38:13]

LGTM

[commit-bot: I haz the power, 2012-07-16 17:13:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10786013/5

[commit-bot: I haz the power, 2012-07-16 18:12:39]

Try job failure for 10786013-5 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-17 10:03:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10786013/5

[commit-bot: I haz the power, 2012-07-17 11:23:01]

Change committed as 146980