Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Side by Side Diff: runtime/vm/object_ia32_test.cc

Issue 10786003: Ensure objects emitted in code are allocated in old space. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address review comments Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/object_x64_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/assert.h" 5 #include "platform/assert.h"
6 #include "vm/globals.h" 6 #include "vm/globals.h"
7 #if defined(TARGET_ARCH_IA32) 7 #if defined(TARGET_ARCH_IA32)
8 8
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/object.h" 10 #include "vm/object.h"
(...skipping 14 matching lines...) Expand all
25 __ incl(ECX); 25 __ incl(ECX);
26 __ popl(EAX); 26 __ popl(EAX);
27 __ movl(EAX, ECX); 27 __ movl(EAX, ECX);
28 __ ret(); 28 __ ret();
29 } 29 }
30 30
31 31
32 // Generate a dart code sequence that embeds a string object in it. 32 // Generate a dart code sequence that embeds a string object in it.
33 // This is used to test Embedded String objects in the instructions. 33 // This is used to test Embedded String objects in the instructions.
34 void GenerateEmbedStringInCode(Assembler* assembler, const char* str) { 34 void GenerateEmbedStringInCode(Assembler* assembler, const char* str) {
35 const String& string_object = String::ZoneHandle(String::New(str)); 35 const String& string_object =
36 String::ZoneHandle(String::New(str, Heap::kOld));
36 __ LoadObject(EAX, string_object); 37 __ LoadObject(EAX, string_object);
37 __ ret(); 38 __ ret();
38 } 39 }
39 40
40 41
41 // Generate a dart code sequence that embeds a smi object in it. 42 // Generate a dart code sequence that embeds a smi object in it.
42 // This is used to test Embedded Smi objects in the instructions. 43 // This is used to test Embedded Smi objects in the instructions.
43 void GenerateEmbedSmiInCode(Assembler* assembler, intptr_t value) { 44 void GenerateEmbedSmiInCode(Assembler* assembler, intptr_t value) {
44 const Smi& smi_object = Smi::ZoneHandle(Smi::New(value)); 45 const Smi& smi_object = Smi::ZoneHandle(Smi::New(value));
45 __ LoadObject(EAX, smi_object); 46 __ LoadObject(EAX, smi_object);
46 __ ret(); 47 __ ret();
47 } 48 }
48 49
49 } // namespace dart 50 } // namespace dart
50 51
51 #endif // defined TARGET_ARCH_IA32 52 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/object_x64_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698