Issue 10785047: Remove all the OS X 10.6 SDK forward declarations.

Issue 10785047: Remove all the OS X 10.6 SDK forward declarations. (Closed)

Created:
8 years, 5 months ago by Robert Sesek

Modified:
8 years, 5 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, yusukes+watch_chromium.org, erikwright (departed), amit, jeremya+watch_chromium.org, dcheng, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jennb, wez+watch_chromium.org, sanjeevr, penghuang+watch_chromium.org, jianli, simonmorris+watch_chromium.org, feature-media-reviews_chromium.org, sergeyu+watch_chromium.org, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, mihaip-chromium-reviews_chromium.org, Dmitry Titov, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, James Su

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Remove all the OS X 10.6 SDK forward declarations. BUG=137676 TEST=compiles TBR=mechanical change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147318

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -687 lines)			Patch
M	base/base.gyp	View	3 chunks	+0 lines, -69 lines	0 comments	Download
D	base/mac/closure_blocks_leopard_compat.h	View	1 chunk	+0 lines, -103 lines	0 comments	Download
D	base/mac/closure_blocks_leopard_compat.S	View	1 chunk	+0 lines, -139 lines	0 comments	Download
D	base/mac/closure_blocks_leopard_compat_unittest.cc	View	1 chunk	+0 lines, -98 lines	0 comments	Download
M	base/mac/cocoa_protocols.h	View	2 chunks	+2 lines, -23 lines	0 comments	Download
M	base/mac/mac_util.mm	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/app_controller_mac.mm	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/browser/mac/security_wrappers.h	View	1 chunk	+1 line, -16 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/base_bubble_controller.mm	View	2 chunks	+0 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/cocoa/browser_window_controller_private.mm	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/panels/panel_window_controller_cocoa.mm	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/chrome_paths_mac.mm	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_mac.mm	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/mac/audio_input_mac.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	media/audio/mac/audio_output_mac.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	net/base/test_root_certs_mac.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	remoting/host/capturer_mac.mm	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	skia/ext/skia_utils_mac.mm	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	ui/gfx/video_decode_acceleration_support_mac.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/gfx/video_decode_acceleration_support_mac.mm	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	webkit/glue/webcursor_mac.mm	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	webkit/glue/webmenurunner_mac.mm	View	1 chunk	+0 lines, -21 lines	0 comments	Download
M	webkit/support/platform_support_mac.mm	View	2 chunks	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Robert Sesek

Mark: Please do the review and then I'll go get OWNERS stamps.

8 years, 5 months ago (2012-07-17 23:49:40 UTC) #1

Mark Mentovai

LGTM. I wouldn’t worry about OWNERS for a sweeping mechanical duh change like this.

8 years, 5 months ago (2012-07-18 16:28:24 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10785047/1

8 years, 5 months ago (2012-07-18 18:24:52 UTC) #3

commit-bot: I haz the power

Try job failure for 10785047-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 5 months ago (2012-07-18 18:44:01 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/10785047/1

8 years, 5 months ago (2012-07-18 21:11:39 UTC) #5

Change committed as 147318

Expand Messages | Collapse Messages