Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10785035: Properly generate MutationCallback in dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/scripts/generator.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index 231fa6b92aaede110b31fedd3d085f52e46341af..ec661bd68bf6640ded5bc809e994713e638e9bf6 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -43,12 +43,13 @@ class NativeImplementationSystem(systembase.System):
parameters = []
arguments = []
+ conversion_includes = []
for argument in operation.arguments:
argument_type_info = self._type_registry.TypeInfo(argument.type.id)
parameters.append('%s %s' % (argument_type_info.parameter_type(),
argument.id))
arguments.append(argument_type_info.to_dart_conversion(argument.id))
- cpp_impl_includes |= set(argument_type_info.conversion_includes())
+ conversion_includes.extend(argument_type_info.conversion_includes())
native_return_type = self._type_registry.TypeInfo(operation.type.id).native_type()
cpp_header_handlers_emitter.Emit(
@@ -56,6 +57,10 @@ class NativeImplementationSystem(systembase.System):
' virtual $TYPE handleEvent($PARAMETERS);\n',
TYPE=native_return_type, PARAMETERS=', '.join(parameters))
+ if 'Custom' in operation.ext_attrs:
+ continue
+
+ cpp_impl_includes |= set(conversion_includes)
arguments_declaration = 'Dart_Handle arguments[] = { %s }' % ', '.join(arguments)
if not len(arguments):
arguments_declaration = 'Dart_Handle* arguments = 0'
« no previous file with comments | « lib/dom/scripts/generator.py ('k') | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698