Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: lib/dom/scripts/dartgenerator.py

Issue 10785035: Properly generate MutationCallback in dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/dom/frog/dom_frog.dart ('k') | lib/dom/scripts/generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/dartgenerator.py
diff --git a/lib/dom/scripts/dartgenerator.py b/lib/dom/scripts/dartgenerator.py
index 713c534927f322cf3552c4d0891c1bb4988dfc13..4d089887c4e7210a9d8c3534e2b0e28cb516204d 100755
--- a/lib/dom/scripts/dartgenerator.py
+++ b/lib/dom/scripts/dartgenerator.py
@@ -35,14 +35,17 @@ class DartGenerator(object):
return type_name.split('::')[-1]
def _IsCompoundType(self, database, type_name):
- if IsPrimitiveType(type_name):
+ if IsRegisteredType(type_name):
return True
+ if type_name.endswith('?'):
+ return self._IsCompoundType(database, type_name[:-len('?')])
+
if type_name.endswith('[]'):
return self._IsCompoundType(database, type_name[:-len('[]')])
- striped_type_name = self._StripModules(type_name)
- if database.HasInterface(striped_type_name):
+ stripped_type_name = self._StripModules(type_name)
+ if database.HasInterface(stripped_type_name):
return True
dart_template_match = self._dart_templates_re.match(type_name)
« no previous file with comments | « lib/dom/frog/dom_frog.dart ('k') | lib/dom/scripts/generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698