Enable aligned_memory_unittest.cc on iOS.

Enable aligned_memory_unittest.cc on iOS.

One case of the StackAlignment test is #defined out for iOS on ARM (not simulator), due to a clang armv7 codegen bug.  A crbug has been created to re-enable these cases when the clang bug is fixed.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147649

[leng, 2012-07-19 13:46:38]

Only 75% of the tests can be run on iOS.  Logged a bug for this.

PTAL, thanks!

[stuartmorgan, 2012-07-19 14:29:13]

LGTM

[leng, 2012-07-19 16:02:08]

Mark, could you take a look, please?  Thanks!

[Mark Mentovai, 2012-07-19 16:20:33]

https://chromiumcodereview.appspot.com/10785019/diff/6001/base/memory/aligned...
File base/memory/aligned_memory_unittest.cc (right):

https://chromiumcodereview.appspot.com/10785019/diff/6001/base/memory/aligned...
base/memory/aligned_memory_unittest.cc:30: #if !defined(OS_IOS)
Can you put CPU_ARCH_ARM or whatever it’s called in the ifdef too? I’d guess
that these tests work properly in the simulator.

[leng, 2012-07-19 17:07:36]

In playing with the ARM flag, I realized the first test passes fine - it's only
the stack test that triggers the clang bug.

https://chromiumcodereview.appspot.com/10785019/diff/6001/base/memory/aligned...
File base/memory/aligned_memory_unittest.cc (right):

https://chromiumcodereview.appspot.com/10785019/diff/6001/base/memory/aligned...
base/memory/aligned_memory_unittest.cc:30: #if !defined(OS_IOS)
On 2012/07/19 16:20:33, Mark Mentovai wrote:
> Can you put CPU_ARCH_ARM or whatever it’s called in the ifdef too? I’d guess
> that these tests work properly in the simulator.

Good idea.  Done.

[Mark Mentovai, 2012-07-19 17:57:09]

LGTM

https://chromiumcodereview.appspot.com/10785019/diff/10001/base/memory/aligne...
File base/memory/aligned_memory_unittest.cc (right):

https://chromiumcodereview.appspot.com/10785019/diff/10001/base/memory/aligne...
base/memory/aligned_memory_unittest.cc:47: #if !defined(OS_IOS) ||
!defined(ARCH_CPU_ARM_FAMILY)
The intent is a little clearer, I think, if you write:

if !(defined(OS_IOS) && defined(ARCH_CPU_ARM_FAMILY))

https://chromiumcodereview.appspot.com/10785019/diff/10001/base/memory/aligne...
base/memory/aligned_memory_unittest.cc:51: #endif  // !OS_IOS
Adjust this to match the #if.

[leng, 2012-07-20 08:37:47]

https://chromiumcodereview.appspot.com/10785019/diff/10001/base/memory/aligne...
File base/memory/aligned_memory_unittest.cc (right):

https://chromiumcodereview.appspot.com/10785019/diff/10001/base/memory/aligne...
base/memory/aligned_memory_unittest.cc:47: #if !defined(OS_IOS) ||
!defined(ARCH_CPU_ARM_FAMILY)
On 2012/07/19 17:57:09, Mark Mentovai wrote:
> The intent is a little clearer, I think, if you write:
> 
> if !(defined(OS_IOS) && defined(ARCH_CPU_ARM_FAMILY))

Agreed.  Done.

https://chromiumcodereview.appspot.com/10785019/diff/10001/base/memory/aligne...
base/memory/aligned_memory_unittest.cc:51: #endif  // !OS_IOS
On 2012/07/19 17:57:09, Mark Mentovai wrote:
> Adjust this to match the #if.

Done.

[commit-bot: I haz the power, 2012-07-20 08:38:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10785019/3003

[commit-bot: I haz the power, 2012-07-20 08:38:14]

Failed to apply patch for base/base.gyp:
While running patch -p1 --forward --force;
patching file base/base.gyp
Hunk #1 FAILED at 572.
1 out of 1 hunk FAILED -- saving rejects to file base/base.gyp.rej

[commit-bot: I haz the power, 2012-07-20 08:43:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10785019/13002

[commit-bot: I haz the power, 2012-07-20 09:52:03]

Try job failure for 10785019-13002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-20 09:55:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10785019/13002

[commit-bot: I haz the power, 2012-07-20 11:01:14]

Try job failure for 10785019-13002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-07-20 12:58:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/leng@chromium.org/10785019/13002

[commit-bot: I haz the power, 2012-07-20 14:13:45]

Change committed as 147649