chrome/browser/extensions/api/web_navigation/web_navigation_api.h - Issue 10785018: Send an webNavigation.onErrorOccurred when a load fails after the initial navigation was committed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

Issue 10785018: Send an webNavigation.onErrorOccurred when a load fails after the initial navigation was committed (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: updates Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

index be16da27e50abe3a3f8be1b82108c8baad58afc1..eace5a1df9e129c6fa2d069f6c7aead197fec045 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.h

@@ -170,6 +170,11 @@ class WebNavigationTabObserver : public content::NotificationObserver,

virtual void DidFinishLoad(int64 frame_id,

const GURL& validated_url,

bool is_main_frame) OVERRIDE;

+ virtual void DidFailLoad(int64 frame_id,

+ const GURL& validated_url,

+ bool is_main_frame,

+ int error_code,

+ const string16& error_description) OVERRIDE;

virtual void DidOpenRequestedURL(content::WebContents* new_contents,

const GURL& url,

const content::Referrer& referrer,

« no previous file with comments | « no previous file | chrome/browser/extensions/api/web_navigation/web_navigation_api.cc » ('j') | no next file with comments »