Issue 10785018: Send an webNavigation.onErrorOccurred when a load fails after the initial navigation was committed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10785018: Send an webNavigation.onErrorOccurred when a load fails after the initial navigation was committed (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 5 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Send an webNavigation.onErrorOccurred when a load fails after the initial navigation was committed BUG=136090 TEST=ExtensionApiTest.WebNavigationFailures Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146998

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -0 lines)			Patch
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/web_navigation/web_navigation_api.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
A	chrome/test/data/extensions/api_test/webnavigation/failures/e.html	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/webnavigation/test_failures.js	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10785018/7001

8 years, 5 months ago (2012-07-17 13:51:50 UTC) #3

Change committed as 146998