Issue 10784040: Fix Win64 build by adding a static_cast.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10784040: Fix Win64 build by adding a static_cast. (Closed)

Created:
8 years, 5 months ago by sanjoy

Modified:
8 years, 5 months ago

Reviewers:
Sven Panne, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix Win64 build by adding a static_cast. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12113

Patch Set 1 #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/hydrogen.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years, 5 months ago (2012-07-18 06:02:21 UTC) #3

http://codereview.chromium.org/10784040/diff/1/src/hydrogen.h
File src/hydrogen.h (right):

http://codereview.chromium.org/10784040/diff/1/src/hydrogen.h#newcode875
src/hydrogen.h:875: return zone->New(static_cast<int>(size));
Again a bit too late, but nevertheless: I think that the right fix is to change
Zone::New to use a size_t. This is the right type and doing it that way would
get rid of this cast and a few others.

Expand Messages | Collapse Messages