Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3828)

Unified Diff: chrome/browser/extensions/settings/settings_api.h

Issue 10784035: Refactored SettingsFrontend and forwarding of calls to the backends. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added comment Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/settings/settings_api.h
diff --git a/chrome/browser/extensions/settings/settings_api.h b/chrome/browser/extensions/settings/settings_api.h
index db96d3dc82d29bbd54340d225fa82537c003f633..c4d0fd5fa60ac553071054a505487e577c9e6cc0 100644
--- a/chrome/browser/extensions/settings/settings_api.h
+++ b/chrome/browser/extensions/settings/settings_api.h
@@ -8,8 +8,8 @@
#include "base/compiler_specific.h"
#include "base/memory/ref_counted.h"
#include "chrome/browser/extensions/extension_function.h"
-#include "chrome/browser/extensions/settings/settings_backend.h"
#include "chrome/browser/extensions/settings/settings_namespace.h"
+#include "chrome/browser/extensions/settings/settings_observer.h"
#include "chrome/browser/value_store/value_store.h"
namespace extensions {
@@ -30,8 +30,7 @@ class SettingsFunction : public AsyncExtensionFunction {
virtual bool RunImpl() OVERRIDE;
// Extension settings function implementations should do their work here.
- // This runs on the FILE thread.
- //
+ // The SettingsFrontend makes sure this is posted to the appropriate thread.
// Implementations should fill in args themselves, though (like RunImpl)
// may return false to imply failure.
virtual bool RunWithStorage(ValueStore* storage) = 0;
@@ -48,7 +47,7 @@ class SettingsFunction : public AsyncExtensionFunction {
private:
// Called via PostTask from RunImpl. Calls RunWithStorage and then
// SendReponse with its success value.
- void RunWithStorageOnFileThread(ValueStore* storage);
+ void AsyncRunWithStorage(ValueStore* storage);
// The settings namespace the call was for. For example, SYNC if the API
// call was chrome.settings.experimental.sync..., LOCAL if .local, etc.
« no previous file with comments | « chrome/browser/extensions/settings/managed_value_store_cache.cc ('k') | chrome/browser/extensions/settings/settings_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698